Repository navigation
vpn: match the bar glyph's colour to the theme accent - #51
Merged
Merged
Conversation
added 2 commits
September 24, 2026 07:49
The bar mark's idle state used Theme.dim (a separate, much lighter ink token) instead of Theme.accent, so the idle key-off glyph and the connected VPN name label both rendered off-white/blank next to every other themed accent-coloured bar icon. Keep both states on the same accent colour and use opacity (1.0 when connected, 0.6 when idle) to convey state instead of switching tokens, matching how the rest of the QS Bar's icons dim.
Collaborator
|
Checked, can be merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VPN plugin's bar glyph (
content/Glyph.qml) painted its idle state withTheme.dimand its connected-state name label withTheme.cream— both separate, much lighter ink tokens thanTheme.accent, which every other QS Bar icon (network, bluetooth, kdeconnect-status, etc.) uses. On the default warm/red palette this makes the idle key-off glyph and the connected VPN name look washed-out/near-white next to the rest of the bar, which reads as a rendering bug (blank icon) rather than an idle state.Fix: keep both the glyph and the bar-text label on
Theme.accentin both states, and use opacity (1.0 connected / 0.6 idle) to convey state instead of switching colour tokens — the same idiom the rest of the bar's dimmable icons already follow.Only
content/Glyph.qml(the topbar host) is touched;content/Card.qml(the desktop-widget host) keeps its own cream/dim palette since it renders on its own card background where that contrast is intentional.Tested locally: reloaded the shell with this file in place of the installed plugin's view and confirmed via screenshot that the idle key-off icon and the connected VPN name now render in the same accent tone as neighbouring bar widgets.