fix(security): sanitize dynamic markup interpolations and validate external URLs (closes #214) - #218
Open
rupesh-kumar-sah wants to merge 2 commits into
Open
rupesh-kumar-sah wants to merge 2 commits into
rupesh-kumar-sah wants to merge 2 commits into
Conversation
…e-211-vendor-sdk-csp fix(security): vendor stellar-sdk and freighter-api with strict CSP (closes SPulse-Org#211)
…ternal URLs (closes SPulse-Org#214)
|
@rupesh-kumar-sah is attempting to deploy a commit to the Muyideen-jsx's projects Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for stellar-pulse ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves #214 by closing the stored and DOM-based Cross-Site Scripting (XSS) attack vectors across frontend dynamic rendering paths.
Changes
frontend/sanitize.js):escapeHtml(str): safely converts&,<,>,", and'to standard HTML entities before template literal interpolation.sanitizeUrl(url): strictly rejects dangerous URL schemes (javascript:,data:,vbscript:) and validates allowable web protocols (https://,/,#).frontend/script.js: Sanitized dynamic market metadata (market.category,market.title,market.detail,market.close), user positions (position.title,position.time,position.stake,position.returns), and validated explorer links (position.explorerUrl).frontend/pages.js: Sanitized market search cards (m.category,m.title,m.close) and leaderboard identities (p.name,p.address).tests/xss-sanitization.test.mjs):<img src=x onerror="...">,<script>...</script>) and malicious URI schemes are neutralized..github/workflows/ci.ymlfrontend verification pipeline.Verification
node scripts/validate-frontend.mjs: Passed (3 HTML pages, 11 source files validated)find frontend -type f -name '*.js' -print0 | xargs -0 -n1 node --check: Passed with 0 syntax errorsnode --test tests/xss-sanitization.test.mjs: All 5 test suites passed 100%Closes #214.