Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously,
window_controlswas an all-or-nothing toggle that rendered all three controls (minimize,maximize,close) in fixed geometries. On certain Window Managers (WM) and Desktop Environments (DE), minimizing windows is unsupported or handled entirely via keybindings, leaving non-functional buttons or unwanted controls in the top bar.With this change applied, we'll have individual configuration options to enable or disable each window control button independently.
The control box width, element hitboxes, and button layouts are now calculated dynamically based on which buttons are active. Remaining controls neatly right-align without leaving dead space or misaligned click zones.
Previews
Testing
all on,only close,min disabled,all disabled).Changes
modernz.lua: Addedwindow_close_button,window_min_button, andwindow_max_buttonoptions and dynamic geometry calculation.modernz.conf: Added the new options to the default configuration template.docs/USER_OPTS.md: Updated the options table in the documentation.