Conversation
dontlaugh
reviewed
May 28, 2026
| updatedBalances: Record<string, number> | undefined, | ||
| metricsUpdated: boolean, | ||
| ): void { | ||
| const entitlements = (getProp(merged, "entitlements", "entitlements") ?? []) as Record<string, unknown>[]; |
Contributor
There was a problem hiding this comment.
Can we do a tighter type constraint than unknown here?
Contributor
Author
There was a problem hiding this comment.
this derives from an issue with the types that we're caching that is being fixed in another PR. so we should fix it when that is resolved.
cbrady
force-pushed
the
chris/schy-380-sdk-entitlement-usage-does-not-update-from-datastream
branch
from
May 29, 2026 18:41
060dbfe to
0529f97
Compare
bpapillon
approved these changes
Jun 1, 2026
cbrady
force-pushed
the
chris/schy-380-sdk-entitlement-usage-does-not-update-from-datastream
branch
from
June 1, 2026 14:42
0529f97 to
89c14c4
Compare
cbrady
deleted the
chris/schy-380-sdk-entitlement-usage-does-not-update-from-datastream
branch
June 1, 2026 14:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.