Skip to content

646 use graph model with ABMs v3 - #1085

Merged
jubicker merged 126 commits into
mainfrom
646-use-graph-model-with-abms-v3
Jan 31, 2025
Merged

646 use graph model with ABMs v3#1085
jubicker merged 126 commits into
mainfrom
646-use-graph-model-with-abms-v3

Conversation

@jubicker

@jubicker jubicker commented Aug 1, 2024

Copy link
Copy Markdown
Member

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • add node property and edge property class for ABM graph simulation
  • add model wrapper for abm that is used for ABM graph simulation and can handle persons that commute to other nodes
  • add tests for new functionality
  • add graph abm example

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@jubicker jubicker linked an issue Aug 1, 2024 that may be closed by this pull request
2 tasks

@DavidKerkmann DavidKerkmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are only a small things left to improve and one discussion item.

Comment thread cpp/models/abm/model.cpp Outdated
Comment thread cpp/models/graph_abm/graph_abm_mobility.h Outdated
Comment thread cpp/models/graph_abm/graph_abmodel.h
Comment thread cpp/models/graph_abm/graph_abmodel.h Outdated
Comment thread cpp/tests/test_graph_abm.cpp
Comment thread cpp/models/abm/person.h Outdated
Comment thread cpp/models/abm/person.h Outdated
Comment thread cpp/models/graph_abm/graph_abmodel.h Outdated

@DavidKerkmann DavidKerkmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Only one point left to discuss from my side.

@DavidKerkmann DavidKerkmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost everything has been resolved, I only have requests for small stylistic changes.

Comment thread cpp/models/abm/person.h
Comment thread cpp/models/abm/person.h
Comment thread cpp/models/abm/person.h Outdated
Comment thread cpp/models/graph_abm/graph_abmodel.h Outdated
Comment thread cpp/models/abm/person.h Outdated
jubicker and others added 4 commits January 30, 2025 10:46
Co-authored-by: David Kerkmann <44698825+DavidKerkmann@users.noreply.github.com>
Co-authored-by: David Kerkmann <44698825+DavidKerkmann@users.noreply.github.com>
Comment thread cpp/models/abm/model.h Outdated
Comment thread cpp/models/abm/model.h Outdated
@jubicker
jubicker merged commit 34a0277 into main Jan 31, 2025
@jubicker
jubicker deleted the 646-use-graph-model-with-abms-v3 branch January 31, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

class::feature A feature to be implemented for some part of the software loc::backend This issue concerns the C++ backend implementation. model::abm This issue concerns any kind of agent-based model.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use graph model with abms

4 participants