Conversation
The assert_eq!(fd.revents, libc::POLLIN) panics when the kernel returns POLLIN | POLLRDNORM in the revents bitmask. The Linux random_poll function returns EPOLLIN | EPOLLRDNORM, and POLLRDNORM is a valid companion event. Use a bitwise check instead to verify POLLIN is set without requiring it to be the only flag. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Documents that poll() revents is a bitmask and the kernel may set multiple flags simultaneously (e.g. POLLIN | POLLHUP). Using assert_eq! instead of bitwise AND fails when extra flags are set. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #380
The Linux kernel's
random_poll()returnsEPOLLIN | EPOLLRDNORMin revents. The strictassert_eq!(fd.revents, libc::POLLIN)panics when POLLRDNORM is also set. Uses a bitwise check instead.