Skip to content

Add per-character handling for hidden Framer's Kit rows - #5

Closed
Daharen wants to merge 4 commits into
Senither:mainfrom
Daharen:contribution/material-shop-manual-offset
Closed

Add per-character handling for hidden Framer's Kit rows#5
Daharen wants to merge 4 commits into
Senither:mainfrom
Daharen:contribution/material-shop-manual-offset

Conversation

@Daharen

@Daharen Daharen commented Aug 4, 2026

Copy link
Copy Markdown

Characters that have not completed the relevant raid content do not see the eleven Framer's Kit rows in the Mathematics (Other) shop.

Because material purchases currently use hard-coded visible-row indices, affected characters purchase an item eleven rows later than configured.

This change:

  • Corrects the current material ordering.
  • Adds a per-character setting indicating whether the raid Framer's Kits are visible.
  • Preserves the existing behavior by default.
  • Subtracts eleven from material-shop callback rows only when the setting is disabled.
  • Does not affect relic purchases or other plugin behavior.

The zero-versus-eleven row discrepancy was reproduced from both shop layouts. A zero-offset fork was tested successfully by an affected user and purchased the intended item.

The integrated per-character checkbox path has not yet been tested across both layouts, so this is being submitted as a draft for review and testing.

@Senither

Senither commented Aug 5, 2026

Copy link
Copy Markdown
Owner

Thanks for taking the time to look into the issue and make this PR. Didn't really think about people not doing the raid content, so they didn't unlock the additional shop items.
I think the general idea behind the system is good, although I don't really like the idea that people have to manage whether they have completed the content and potentially buy the wrong item(s) if they forget to tick a checkbox.
A better solution that would future-proof it for new expansions might be to buy items based on the Item ID instead of the hard-coded index; it would require a bit of rewriting for the tome shop system, but in turn should make it consistent regardless of new items being added.
I'll have a look at the system again to make some changes that should work for everyone. Thanks again for bringing it up tho.

@Senither

Senither commented Aug 5, 2026

Copy link
Copy Markdown
Owner

The new version v0.21.0.2 should now correctly buy the item you've selected, regardless of if you've done the raid content to unlock the framer's kits or not.

Thanks again for taking the time to look at this issue, and for brining it to my attention.

@Senither Senither closed this Aug 5, 2026
@Daharen

Daharen commented Aug 5, 2026

Copy link
Copy Markdown
Author

Appreciate the work, thank you :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants