Add a client-wide default for the synchronized operation flag - #1
Merged
Conversation
The payment operation methods (authorize/capture/refund/cancel) now take ?bool $synchronized = null, falling back to a new 'synchronized' flag on the Client constructor (exposed as ClientInterface::isSynchronized()). Integrations that always want to wait for the completed transaction can set the default once instead of repeating the flag on every call; a non-null per-call argument still overrides it.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Call sites that always want synchronized operations currently have to repeat the flag on every call:
Whether to wait for the completed transaction is almost always an integration-wide decision, not a per-call one — so it belongs on the client, not at every call site. (It deliberately does not move into the request DTOs:
?synchronizedis a query flag rather than body data, thePayloadDTOs map 1:1 to Quickpay's documented request bodies, andcancel()has no body DTO at all.)What
Clientconstructor gains abool $synchronized = falseparameter (appended last — BC for positional callers), exposed asisSynchronized()onClientInterface.authorize/capture/refund/cancel) changebool $synchronized = false→?bool $synchronized = null;nullfalls back to the client-wide default, a non-null argument overrides it. Behavior is unchanged for existing code.BC note
Adding
isSynchronized()toClientInterfacebreaks custom implementations/decorators of that interface (if any exist). Consumers usingClientdirectly are unaffected.Tests
false/ constructor flag is exposed viaisSynchronized().synchronized: trueclient appends?synchronizedwithout a per-call flag.synchronized: falseoverrides atrueclient default.