Verify leak reproduction before bisecting - #421
Closed
acaron wants to merge 1 commit into
Closed
Conversation
A truncated suspect list can omit the polluter and make binary search choose an arbitrary culprit. Check the full suspect order once and stop cleanly when the victim passes. Co-authored-by: GPT-5.6-sol <noreply@openai.com> Orchestrated-by: ae <noreply@shopify.com> Assisted-By: devx/4e8e30c1-9040-49b1-9230-c9e1fd1758c1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minitest bisect assumes the leak reproduces somewhere in the suspect list. When truncation omits the polluter, every fork passes and binary search narrows to an arbitrary suspect before reporting an inconclusive result.
Run the complete suspect order once before binary search. If the victim passes, stop successfully, clear the bisect output logs, and report that there is no leak to bisect. Keep the first-test shortcut ahead of this check and bump
ci-queueto 0.98.0.Co-authored-by: GPT-5.6-sol noreply@openai.com
Orchestrated-by: ae noreply@shopify.com