Stratum v2 handshake using EllSwift - #28
Closed
Sjors wants to merge 3 commits into
Closed
Conversation
Sjors
marked this pull request as ready for review
January 9, 2024 14:05
Sjors
force-pushed
the
2024/01/sv2-ellswift
branch
3 times, most recently
from
January 9, 2024 16:50
a1f476f to
a32c20d
Compare
Sjors
force-pushed
the
2023/11/sv2-poll
branch
3 times, most recently
from
January 12, 2024 15:57
7a2b96c to
85c3e9e
Compare
This was referenced Jan 12, 2024
Sjors
force-pushed
the
2023/11/sv2-poll
branch
2 times, most recently
from
January 15, 2024 11:55
aa952cb to
d5d9695
Compare
Sjors
force-pushed
the
2024/01/sv2-ellswift
branch
from
January 15, 2024 12:45
a32c20d to
26bf4db
Compare
Sjors
force-pushed
the
2023/11/sv2-poll
branch
from
January 15, 2024 16:48
d5d9695 to
2a9f7d1
Compare
Sjors
force-pushed
the
2024/01/sv2-ellswift
branch
from
January 15, 2024 17:05
26bf4db to
e2ec1e6
Compare
Sjors
force-pushed
the
2023/11/sv2-poll
branch
from
January 15, 2024 17:37
2a9f7d1 to
d4d3dad
Compare
Sjors
force-pushed
the
2024/01/sv2-ellswift
branch
from
January 15, 2024 17:38
e2ec1e6 to
aa37769
Compare
Sjors
force-pushed
the
2023/11/sv2-poll
branch
from
January 15, 2024 18:47
d4d3dad to
f00b310
Compare
Sjors
force-pushed
the
2024/01/sv2-ellswift
branch
from
January 15, 2024 18:47
aa37769 to
639de78
Compare
Sjors
force-pushed
the
2023/11/sv2-poll
branch
from
January 15, 2024 19:39
f00b310 to
3bb4604
Compare
Sjors
force-pushed
the
2024/01/sv2-ellswift
branch
from
January 15, 2024 19:44
639de78 to
a10a334
Compare
Sjors
force-pushed
the
2023/11/sv2-poll
branch
from
January 16, 2024 10:25
3bb4604 to
cfbdf2b
Compare
This reverts commit 6eb5e14c773a0c8140d2ae07bb371688a8d9669d.
This reverts commit eb51cd2497a72be7cc2572cc56c1ba68fc7873bd.
Sjors
force-pushed
the
2024/01/sv2-ellswift
branch
2 times, most recently
from
January 16, 2024 16:56
4226418 to
345e112
Compare
Sjors
force-pushed
the
2024/01/sv2-ellswift
branch
from
January 16, 2024 16:59
345e112 to
f167acf
Compare
Sjors
force-pushed
the
2024/01/sv2-ellswift
branch
27 times, most recently
from
January 16, 2024 22:42
b36b070 to
24219f3
Compare
This was referenced Jan 22, 2024
Closed
Owner
Author
|
This is now included in https://github.com/Sjors/bitcoin/tree/2024/02/sv2-poll-ellswift |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements stratum-mining/sv2-spec#66.
Matching SRI pull request: stratum-mining/stratum#737
This changes the handshake in two ways:
ellswift_ecdh_xonlyBoth are defined in BIP324
It does not change (x-only) public encoding in the certificate.
The main implementation is in commit "Use EllSwift for handshake pubkeys and ECDH". The two revert commits allow dropping their corresponding commits in bitcoin#28983