Conversation
Currently, if using `dayBarTextStyle` from `WeekViewStyle`, this value is fixed, not be able to configure according to date value, so we cannot highlight the current date in day bar. My solution is to use `dayBarTextStyle` of `DayViewStyle` if it is provided.
add `initialDateIndex` to control the first date visible in WeekView
Author
|
cc @Skyost |
Owner
|
Hey @hnvn, I'm not able to review it right now. I will be able next week I think. |
Contributor
|
The second commit ("support customize dayBarTextStyle") has many changes which are only code reformatting, probably due to automatic reformatting. Could you remove those, please? That would make it easier to review the PR and keep the formatting more consistent across the code :) Also, the pubspec.lock file should rather not be committed in library packages. Could you remove it please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customize TextStyle of current day on day bar: currently, if using
dayBarTextStylefromWeekViewStyle, this value is fixed, not be able to configure according to date value, so we cannot highlight the current date on day bar. My solution is to usedayBarTextStyleofDayViewStyleif it is provided.Support configure the first day visible on
WeekView: currently,WeekViewcan only jump immediately to the current time (current day). I add newinitialDateIndexinWeekViewto configure the first day visible onWeekView.