Skip to content

ci(simulation): carry results as annotations, not artifacts #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Julian Gruber (juliangruber) wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ci(simulation): carry results as annotations, not artifacts #23

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64040f1
ci(simulation): carry results as annotations, not artifacts
juliangruber Sep 30, 2026
188601c
Update .github/workflows/test-sfw-ci-simulation.yml
juliangruber Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 19 additions & 21 deletions .github/workflows/test-sfw-ci-simulation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,19 +168,12 @@ jobs:
grep -q "UV_HANDLE_CLOSING" run.log && category=libuv-assertion
grep -q "fetch failed" run.log && category=telemetry-fetch-failed
fi
mkdir -p results
printf '{"os":"%s","variant":"%s","iteration":%s,"actionOutcome":"%s","exit":"%s","category":"%s"}\n' \
"$OS" "$VARIANT" "$ITERATION" "$ACTION_OUTCOME" "${RUN_EXIT:-}" "$category" \
> "results/install-$OS-$VARIANT-$ITERATION.json"
printf '::notice title=sim-result::{"os":"%s","variant":"%s","iteration":%s,"actionOutcome":"%s","exit":"%s","category":"%s"}\n' \
"$OS" "$VARIANT" "$ITERATION" "$ACTION_OUTCOME" "${RUN_EXIT:-}" "$category"
echo "category=$category exit=${RUN_EXIT:-}"
if [ "$category" != ok ]; then
echo "::group::run.log"; tail -40 run.log; echo "::endgroup::"
fi
- name: 'Upload the result'
uses: ./.github/actions/fleet/upload-artifact
with:
name: result-install-${{ matrix.os }}-${{ matrix.variant }}-${{ matrix.iteration }}
path: results/

report:
needs: [plan, install]
Expand Down Expand Up @@ -211,10 +204,19 @@ jobs:
export GIT_CONFIG_VALUE_0="AUTHORIZATION: basic ${AUTH_B64}"
git fetch --no-tags --prune --depth 1 origin "${TRIGGER_REF}"
git checkout -q --detach FETCH_HEAD
- name: 'Download the results'
uses: ./.github/actions/fleet/download-artifact
with:
path: results
- name: 'Collect the results from the install jobs'
shell: bash
env:
GH_TOKEN: ${{ github.token }}
RUN_ID: ${{ github.run_id }}
REPO: ${{ github.repository }}
run: |
set -euo pipefail
: > results.jsonl
for url in $(gh api "repos/$REPO/actions/runs/$RUN_ID/jobs?per_page=100" --paginate --jq '.jobs[] | select(.name | startswith("Install (")) | .check_run_url'); do
gh api "$url/annotations" --jq '.[] | select(.title=="sim-result") | .message' >> results.jsonl
done
echo "collected $(wc -l < results.jsonl) result(s)"
- name: 'Write the flake table'
shell: bash
env:
Expand All @@ -229,13 +231,13 @@ jobs:
echo
echo "| runner | variant | runs | ok | failures by category |"
echo "| --- | --- | ---: | ---: | --- |"
find results -name 'install-*.json' -print0 | xargs -0 cat | jq -r -s '
jq -r -s '
group_by(.os, .variant)[]
| {os: .[0].os, variant: .[0].variant, runs: length,
ok: (map(select(.category=="ok")) | length),
cats: (map(select(.category!="ok") | .category) | group_by(.) | map("\(.[0]) 脳\(length)") | join(", "))}
| "| \(.os) | \(.variant) | \(.runs) | \(.ok) | \(.cats) |"'
} >> "$GITHUB_STEP_SUMMARY"
| "| \(.os) | \(.variant) | \(.runs) | \(.ok) | \(.cats) |"' results.jsonl
} | tee -a "$GITHUB_STEP_SUMMARY"
# Binary download failures happen inside the action step and are counted
# above as action-setup-failed. The action reports them as a failure
# annotation, which is readable here even though the step output is not.
Expand All @@ -253,8 +255,4 @@ jobs:
d=$(gh api "$url/annotations" --jq '[.[] | select(.message | test("Failed to download Socket Firewall binary"))] | length')
setup=$((setup + n)); downloads=$((downloads + d))
done
{
echo
echo "action-setup-failed breakdown: $downloads of $setup failure annotations name a binary download failure."
} >> "$GITHUB_STEP_SUMMARY"
cat "$GITHUB_STEP_SUMMARY"
echo "action-setup-failed breakdown: $downloads of $setup failure annotations name a binary download failure." | tee -a "$GITHUB_STEP_SUMMARY"
Loading