Clarify upgrade log: plain-language phases and ASCII errors#421
Merged
Conversation
Operator feedback on the web-surfaced Windows upgrade log: - Replace "Phase A/B" jargon with plain language: "Preparing upgrade to X", "Installing X", "Upgrade complete". The structured event phase field stays 'A'/'B' (the events-parity contract); only the human-readable log text changes. - Exception messages on a non-Latin OS (e.g. Chinese Windows) were localized and rendered as mojibake in the web log. Force the thread UI culture to en-US so .NET errors come through in English, and ASCII-sanitize every log line as a belt-and-braces guarantee.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Operator feedback on the web-surfaced Windows upgrade log (1.8.15):
Preparing upgrade to <version>,Installing <version>,Upgrade complete. The structured eventphasefield staysA/B(the events-parity data contract); only the human-readable log text changes. The web UI relabels the timeline[A]/[B]→[Prep]/[Install](SquidWeb PR).ʹ�á�...). Force the thread UI culture toen-USso .NET errors come through in English, and ASCII-sanitize everyAppend-UpgradeLogline as a belt-and-braces guarantee.Test plan
.ps1runs end-to-end with the reworded log + culture set