Make deployment kill-timeout configurable via env var#423
Merged
Conversation
The 60-minute pipeline kill-timer was a hardcoded internal-init constant with no operator override, so any deployment legitimately exceeding 60 minutes (large DB migrations, multi-stage rollouts) was force-cancelled with no escape hatch — a violation of the repo's own env-var override convention. Add SQUID_DEPLOYMENT_TIMEOUT_MINUTES following the established ParseMaxPendingWorkPerAgent pattern: a pure static parser with a safe fallback to the 60-minute default on blank, invalid, or non-positive input. Leaving the variable unset preserves the historical behaviour exactly, so the change is purely additive and non-breaking.
ppXD
force-pushed
the
fix/configurable-deployment-timeout
branch
from
June 10, 2026 08:02
19bb19e to
a3b6ec7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeploymentPipelineRunnerwas a hardcodedinternal initconstant with no operator override — any deployment legitimately exceeding 60 minutes (large DB migrations, multi-stage rollouts) was force-cancelled with no escape hatch.SQUID_DEPLOYMENT_TIMEOUT_MINUTESfollowing the establishedHalibutPollingWorkAdmission.ParseMaxPendingWorkPerAgentpattern: a pure static parser (ParseDeploymentTimeout) with a safe fallback to the 60-minute default on blank / invalid / non-positive input, plus a thin env reader wired into the property's default initializer.public const/internal const/public staticmembers. With the variable unset the effective timeout is byte-identical to the previous 60-minute behaviour.Test plan
[Theory]overParseDeploymentTimeout(null / empty / whitespace / valid / surrounding-whitespace / large / equal-to-default / garbage / decimal / zero / negative)DeploymentTimeout; env-unset falls back to 60 min (env saved/restored, isolation-safe distinct value)Services.Deploymentsnamespace 3981/3981 green; all 4DeploymentPipelineRunner*test classes 42/42 greendotnet build src/Squid.Core— 0 errors