fix(withdraw): ignore user-cancelled passkey signing errors - #2542
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where Sentry was logging
TurnkeyActivityError: Failed to sign: The user cancelled the request.when users dismissed the passkey/Turnkey prompt during the EIP-712 signing step in theuseWithdrawRainCollateralhook.Root Cause:
The
smartAccountClient.account.signTypedDatacall (Step 4) occurs beforeexecuteTransactions(Step 5). When a user cancelled the passkey prompt during this signing step, the error bypassed theisWebAuthnUserCancelledErrorguard, which was only present withinexecuteTransactions. Consequently,Sentry.captureExceptionwas called unconditionally, leading to unnecessary error reports.Changes Made:
isWebAuthnUserCancelledError: AddedisWebAuthnUserCancelledErrorto the import statement from@/lib/executeinhooks/useWithdrawRainCollateral.ts.catchblock ofuseWithdrawRainCollateral.tsto detect user-cancelled WebAuthn errors. IfisWebAuthnUserCancelledError(err)returns true, Sentry capture is skipped, and the hook's status is set toStatus.IDLE(instead ofStatus.ERROR), treating it as a user-initiated cancellation rather than an application error.hooks/__tests__/useWithdrawRainCollateral.test.tsxwith tests to ensure Sentry is not called for user cancellations and is called for other types of errors during the signing process.This change reduces Sentry noise and accurately reflects user intent when cancelling a passkey prompt.
Fixes SOLID-W5
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.