fix(withdraw): prevent user cancellations from being reported as Sentry errors - #2543
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when a user cancelled a transaction initiated via the
useWithdrawhook (e.g., by dismissing their wallet prompt), the resultingError: User cancelled transactionwas unconditionally captured by Sentry. This led to false-positive error reports, cluttering Sentry with expected user behavior.This change guards the
Sentry.captureExceptioncall inhooks/useWithdraw.tswithif (!isUserCancelledError(error)). TheisUserCancelledErrorutility already existed and was used for analytics, but not for Sentry reporting. Now, deliberate user cancellations will no longer be reported as errors.New unit tests have been added for
useWithdrawto ensure that Sentry is not called for user cancellations but is correctly called for other types of errors.Fixes SOLID-VS
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.