fix(signup): ignore user-cancelled passkey creation in Sentry - #2551
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue SOLID-S3, where user-initiated cancellations during passkey creation were being reported as Sentry errors.
Root Cause:
The
catchblock inapp/signup/passkey.tsxwas unconditionally callingSentry.captureExceptionfor all errors. When a user cancels the passkey prompt, the Turnkey SDK wraps the browser'sNotAllowedErrorinto aTurnkeyErrorwith the message "Passkey creation was cancelled by the user.". This was incorrectly logged as an application error.Changes Made:
app/signup/passkey.tsx:isPasskeyPromptErrorutility.if (isPasskeyPromptError(err)) return;beforeSentry.captureException(line 118). This ensures that user-initiated cancellations, which are expected user behavior, are no longer sent to Sentry.lib/utils/__tests__/passkey-credentials.test.ts:isPasskeyPromptErrorsuite to explicitly verify that aTurnkeyErrorwith the cancellation message is correctly identified as a passkey prompt error.This fix prevents noise in Sentry by distinguishing between genuine application errors and expected user interactions.
Fixes SOLID-S3
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.