fix: guard token fetch against undefined safeAddress - #2557
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the "Error fetching tokens" issue (SOLID-VF) which occurred when
checkBalance()inhooks/useUser.tscalledfetchIsDeposited()with anundefineduser.safeAddress.The root cause was that
fetchIsDepositeddirectly usedqueryClient.fetchQuery(), bypassing theenabled: !!safeAddressguard defined inisDepositedQueryOptions. This resulted in a GraphQL query being sent withaddress: undefined, leading to aCombinedGraphQLErrorsresponse from The Graph API.Changes Made:
hooks/useAnalytics.tswithinfetchIsDeposited. IfsafeAddressisundefinedor falsy, it now immediately returnsPromise.resolve(0), preventing the invalid GraphQL query.safeAddressparameter in bothisDepositedQueryOptionsandfetchIsDepositedfromstringtostring | undefinedto accurately reflect its potential state and improve type safety.Fixes SOLID-VF
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.