Skip to content

fix: Downgrade Android passkey cancellation errors - #2560

Open
sentry[bot] wants to merge 1 commit into
masterfrom
seer/fix/downgrade-android-passkey-errors
Open

sentry[bot] wants to merge 1 commit into
masterfrom
seer/fix/downgrade-android-passkey-errors

Conversation

@sentry

@sentry sentry Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

This PR addresses an issue where user-cancelled passkey login prompts on Android devices were being captured as full Sentry errors instead of warnings.

Problem: On Android, when a user cancels a passkey prompt, the resulting error has a name of 'UserCancelled' and a message like 'The user cancelled the request.'. The login error handling in hooks/useUser.ts (line 426) was only checking for error?.name === 'NotAllowedError' (which is typical for iOS/web cancellations), causing Android cancellations to fall through to the default error capture path (Sentry.captureException).

Solution:

  1. Imported isWebAuthnUserCancelledError from @/lib/execute into hooks/useUser.ts.
  2. Modified the condition in the login catch block to include isWebAuthnUserCancelledError(error). This ensures that Android-specific user cancellation errors are now correctly identified and downgraded to a Sentry warning (Sentry.captureMessage), aligning their treatment with iOS/web cancellations.

This change reduces noise in Sentry by preventing expected user-initiated cancellations from being reported as critical errors.

Fixes SOLID-10C

@sentry <feedback>: Autofix iterates on these changes
@sentry stop iterating: Autofix stops iterating on this run

This PR was automatically generated by Sentry. You can adjust this setting at any time.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@vercel

vercel Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
solid-app Ignored Ignored Preview Sep 23, 2026 10:39am UTC
solid-app-staging Ignored Ignored Preview Sep 23, 2026 10:39am UTC

Request Review

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants