fix: silence CancelledError Sentry reports in usePostSignupInit - #2567
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where
CancelledErrorexceptions were being incorrectly reported to Sentry from theusePostSignupInithook.Problem:
When a user's session expires or they log out,
handleSessionExpired(inhooks/useUser.ts) callsqueryClient.clear(). This action cancels all in-flight TanStack Query fetches, causing them to reject with aCancelledError. ThefetchIsDepositedcall withinusePostSignupInit.tswas susceptible to this, and its catch block was unconditionally capturing these expectedCancelledErrorinstances and sending them to Sentry asbalance_check_error_lazywarnings.Solution:
Added a guard in the
fetchIsDepositedcatch block withinhooks/usePostSignupInit.tsto check if the caught error is aCancelledError. If it is, the error is silently ignored, preventing it from being reported to Sentry. This aligns with the existing pattern for handlingAbortErrorinlib/utils/utils.ts.Verification:
hooks/__tests__/usePostSignupInit.test.ts) to specifically verify thatCancelledErroris not reported to Sentry, while other unexpected errors still are.npm run lintandnpm testto ensure no new issues were introduced.Fixes SOLID-W7
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.