fix(deposit): prevent user-cancelled errors from being sent to Sentry - #2583
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue SOLID-VA where Sentry was receiving "Error: User cancelled transaction" events from the deposit flow.
Root Cause:
The
captureDepositErrorfunction inlib/deposit/telemetry.tsunconditionally calledSentry.captureExceptionfor all errors. When a user intentionally cancelled a deposit transaction,hooks/useDepositFromSolidUsdc.tswould thrownew Error('User cancelled transaction'), which was then captured by Sentry as an error, leading to noise in error monitoring.Solution:
captureDepositErrorto check if the error is a user cancellation usingisUserCancelledError(from@/lib/utils/withdrawErrors).Sentry.captureExceptionis now only called for genuine errors, aligning with the existing pattern in the withdraw flow (hooks/useWithdraw.ts).user_cancelledflag to theTRACKING_EVENTS.DEPOSIT_ERRORanalytics event. This ensures that user cancellations are still tracked for analytical purposes without generating Sentry alerts.lib/deposit/__tests__/telemetry.test.tsto specifically test the behavior ofcaptureDepositError, ensuring Sentry is correctly bypassed for user cancellations and still captures other errors.This change reduces Sentry noise by filtering out expected user interactions while maintaining visibility into these events for analytics.
Fixes SOLID-VA
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.