fix(sentry): suppress user cancelled transaction errors in useSend - #2584
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where Sentry was reporting "Error: User cancelled transaction" events from
hooks/useSend.tsas actual errors.Problem:
When a user deliberately cancelled a transaction initiated via
useSend.ts(e.g., by dismissing a biometric or passkey prompt), theUSER_CANCELLED_TRANSACTIONsentinel was converted into a genericError('User cancelled transaction')and then unconditionally captured by Sentry. This led to false-positive error reports, creating noise in Sentry and obscuring genuine issues.Root Cause:
Unlike
hooks/useWithdraw.ts, which correctly uses theisUserCancelledErrorutility to prevent Sentry from capturing user-initiated cancellations,hooks/useSend.tslacked this guard.Solution:
isUserCancelledErrorfrom@/lib/utils/withdrawErrorsintohooks/useSend.ts.Sentry.captureExceptioncall inhooks/useSend.tswith anif (!isUserCancelledError(error))condition.This change ensures that user-initiated cancellations are no longer reported to Sentry as errors, reducing noise and improving the signal-to-noise ratio for actual issues.
Fixes SOLID-K6
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.