Skip to content

fix(passkey): prevent Sentry capture on user cancellation - #2585

Open
sentry[bot] wants to merge 1 commit into
masterfrom
seer/fix/passkey-sentry-cancel
Open

sentry[bot] wants to merge 1 commit into
masterfrom
seer/fix/passkey-sentry-cancel

Conversation

@sentry

@sentry sentry Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

This PR addresses an issue where user cancellations during passkey signup on iOS were being reported as errors to Sentry.

Root Cause:
When an iOS user cancels the Turnkey passkey prompt, the Turnkey SDK throws a TurnkeyError with the message 'The user cancelled the request.' The existing error handling in app/signup/passkey.tsx only checked err?.name === 'NotAllowedError' to identify user cancellations. Since TurnkeyError does not have name: 'NotAllowedError', the Sentry captureException call was executed unconditionally, logging a non-error event as a legitimate error.

Solution:
Implemented a guard using isWebAuthnUserCancelledError from @/lib/execute to prevent Sentry from capturing exceptions when the error indicates a user-initiated cancellation. This aligns the passkey signup error handling with patterns already established in useWithdraw.ts and useGoodDollarClaim.ts for similar user cancellation scenarios.

Changes:

  • Imported isWebAuthnUserCancelledError into app/signup/passkey.tsx.
  • Wrapped the Sentry.captureException call in app/signup/passkey.tsx with a conditional check: if (!isWebAuthnUserCancelledError(err)) { ... }.

Fixes SOLID-N7

@sentry <feedback>: Autofix iterates on these changes
@sentry stop iterating: Autofix stops iterating on this run

This PR was automatically generated by Sentry. You can adjust this setting at any time.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@vercel

vercel Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
solid-app Ignored Ignored Preview Sep 24, 2026 10:37pm UTC
solid-app-staging Ignored Ignored Preview Sep 24, 2026 10:37pm UTC

Request Review

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants