fix(passkey): prevent Sentry capture on user cancellation - #2585
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where user cancellations during passkey signup on iOS were being reported as errors to Sentry.
Root Cause:
When an iOS user cancels the Turnkey passkey prompt, the Turnkey SDK throws a
TurnkeyErrorwith the message 'The user cancelled the request.' The existing error handling inapp/signup/passkey.tsxonly checkederr?.name === 'NotAllowedError'to identify user cancellations. SinceTurnkeyErrordoes not havename: 'NotAllowedError', the SentrycaptureExceptioncall was executed unconditionally, logging a non-error event as a legitimate error.Solution:
Implemented a guard using
isWebAuthnUserCancelledErrorfrom@/lib/executeto prevent Sentry from capturing exceptions when the error indicates a user-initiated cancellation. This aligns the passkey signup error handling with patterns already established inuseWithdraw.tsanduseGoodDollarClaim.tsfor similar user cancellation scenarios.Changes:
isWebAuthnUserCancelledErrorintoapp/signup/passkey.tsx.Sentry.captureExceptioncall inapp/signup/passkey.tsxwith a conditional check:if (!isWebAuthnUserCancelledError(err)) { ... }.Fixes SOLID-N7
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.