fix(login): Correctly handle iOS Turnkey user cancellations - #2586
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where user-initiated cancellations during the login process on iOS devices were being incorrectly reported as critical errors in Sentry.
Problem:
On iOS, when a user cancels the biometric or passkey prompt during login (e.g., via Turnkey), the error object returned by Turnkey has the shape
{ error: 'UserCancelled' }. However, theuseUser.tslogin catch block was only checking forerror?.name === 'NotAllowedError'to identify user cancellations. This mismatch caused legitimate user cancellations to fall through to the generic error capture, leading to falseError logging inreports in Sentry.Solution:
isWebAuthnUserCancelledError: The shared utility functionisWebAuthnUserCancelledErrorinlib/execute.tshas been extended to include a check forerror?.error === 'UserCancelled'. This makes the helper robust enough to identify Turnkey's iOS-specific cancellation signal.useUser.ts: The login error handling inhooks/useUser.tsnow utilizes the enhancedisWebAuthnUserCancelledErrorhelper. This ensures that user cancellations on iOS are correctly identified and handled as warnings (or silently), preventing them from being reported as errors.Impact:
This fix reduces Sentry noise by accurately classifying user cancellations during iOS login, providing a clearer view of actual login failures.
Fixes SOLID-115
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.