fix(execute): misclassify Turnkey API errors as user cancellations - #2587
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue SOLID-D5, where actual Turnkey API failures were being misclassified as
Error: User cancelled transaction.Problem:
The
isWebAuthnUserCancelledErrorfunction inlib/execute.tscontained an overly broad check (message.includes('failed to sign')). This caused legitimate Turnkey API errors, such as "Failed to sign: Turnkey error 3: activity timestamp is not current", to be incorrectly identified as user-initiated passkey cancellations. As a result, the application would report a generic "User cancelled transaction" error, obscuring the true underlying API failure from both users and Sentry.Solution:
isWebAuthnUserCancelledError: The problematicisWebAuthnUserCancelledErrorfunction was removed fromlib/execute.ts.isPasskeyPromptError: The existing and more preciseisPasskeyPromptErrorfunction fromlib/utils/passkey.tsis now used inlib/execute.ts(for transaction execution error handling) andhooks/useWirexThreeDs.ts(for 3DS flow error handling). This function correctly distinguishes between user cancellations and actual API errors.lib/utils/__tests__/passkey-credentials.test.tsto specifically assert thatisPasskeyPromptErrorreturnsfalsefor Turnkey API error messages, ensuring the fix holds.This change ensures that real API failures are no longer silently swallowed and are reported accurately.
Fixes SOLID-D5
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.