fix(deposit): list Cash App under USD on Fund your card - #2601
Merged
Merged
Conversation
Cash App was a row of its own at the bottom of "Fund your card", in the Other group, while the wallet flow lists it under USD beside Apple Pay. The card screens now do the same. - Rain (mobile and desktop): USD opens "Deposit US Dollars", which lists Wire transfer/ACH, Cash App where the server allows it, and Apple Pay. The USD row's chips name Cash App when it is offered, and back from the Cash App amount screen returns to the USD methods rather than the list. - Wirex has no USD section, so it no longer offers Cash App at all. Its modal is back to what it was before Cash App was added to it, and the Other group's Cash App row goes with its last caller. - The USD chips come from one getUsdMethodChips helper beside UsdMethodList, shared by the wallet's cash list and the card options, so the two USD rows cannot drift apart. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cash App was a row of its own at the bottom of "Fund your card", in the Other group, while the wallet flow lists it under USD beside Apple Pay. The card screens now do the same.
Rain (mobile and desktop). USD opens "Deposit US Dollars", which lists Wire transfer/ACH, Cash App where the server allows it, and Apple Pay — the same
UsdMethodListthe wallet uses. The USD row's chips read ACH · Wire · Cash App · Apple Pay when Cash App is offered, and back from the Cash App amount screen returns to the USD methods, as it already did for Apple Pay's widget, rather than to the top of the list.Wirex. Its funding screen has no USD section, so it no longer offers Cash App at all.
WirexCardFundModalis back to exactly what it was before #2595 added Cash App to it, and the Other group's Cash App row inCardFundOptionsgoes with its last caller. ThecashDepositsection flag now says that USD's methods, Cash App included, come and go with it.Chips. The USD row's chips come from one
getUsdMethodChipshelper besideUsdMethodList, shared by the wallet's cash list and the card options, so the two USD rows cannot drift apart. The wallet screen renders exactly as before.Testing. New
components/Card/__tests__/CardFundOptions.test.tsxcovers the Rain row with and without Cash App, and Wirex offering none; its main case fails against the previousCardFundOptions. Full jest suite passes (135 suites, 1561 tests); eslint and prettier are clean;tscreports no errors in the changed files. Not yet checked in the running app, which needs a signed-in Rain cardholder with Cash App available.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.