feat(recovery): prefill the identifier, and accept a username - #2602
Merged
Merged
Conversation
The recovery screen opened on an empty email field. The user this came from reached it twice on a phone, sat on that field both times, and left without typing anything — then told support the recovery interface would not open. Their own screen recording shows it opening fine. Prefill it from the account this device last knew about. Logging out and a session expiring both leave that row behind — only "Forget all users" clears it — so on the device someone is locked out of, it is almost always the account they are reaching for. The field now takes a username as well, for the roughly one account in ten that carries no email and for anyone who cannot remember which inbox they used. Validation only holds an entry to the email rules once it contains an "@"; which account it names is the server's call. The OTP step then says where the code actually went, from the masked hint the backend returns, because a username recovery never learns the address — and for the same reason it no longer sends one back on verify. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HRh59soi7iX4J3UwxVVGRS
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recovery screen opened on an empty email field. The user this came from reached it twice on a phone, sat on that field both times, and left without typing anything — then told support the recovery interface would not open. Their own screen recording shows it opening fine.
Prefill it from the account this device last knew about. Logging out and a session expiring both leave that row behind — only "Forget all users" clears it — so on the device someone is locked out of, it is almost always the account they are reaching for.
The field now takes a username as well, for the roughly one account in ten that carries no email and for anyone who cannot remember which inbox they used. Validation only holds an entry to the email rules once it contains an "@"; which account it names is the server's call. The OTP step then says where the code actually went, from the masked hint the backend returns, because a username recovery never learns the address — and for the same reason it no longer sends one back on verify.
Claude-Session: https://claude.ai/code/session_01HRh59soi7iX4J3UwxVVGRS
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.