fix(deposit): hide the USD bank rail from Wirex cardholders - #2603
Merged
Merged
Conversation
A Wirex cardholder's "Add funds" opens the wallet deposit flow, whose USD step offered "Wire transfer, ACH". Nothing sent that way reaches their card: the Wirex virtual account has no wire rail, and what it receives settles into the Wirex balance rather than the Safe the card spends from. "Fund your card" already leaves the rail off for Wirex (WIREX_CARD_FUND_SECTIONS.cashDeposit). - canFundByUsdBankTransfer(provider) is false for a Wirex card. - DepositUsdOptions drops the bank row for them; Apple Pay and Cash App stay. - getUsdMethodChips takes a hasBankTransfer flag, so the cash list's USD row stops naming ACH and Wire for them too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
A Wirex cardholder's "Add funds" (the card screen action row and home) opens the wallet deposit flow. Its Cash → USD step offered Wire transfer, ACH, and the USD row's chips named ACH and Wire. Nothing sent that way reaches the card:
"Fund your card" already leaves this rail off for Wirex (
WIREX_CARD_FUND_SECTIONS.cashDeposit: false). The wallet flow now matches it.canFundByUsdBankTransfer(provider)inlib/utils/cardHelpers.tsis false for a Wirex card.UsdMethodListtakes an optionalonBankTransferPress.DepositUsdOptionsleaves it out for Wirex cardholders, and Apple Pay and Cash App (where offered) stay.getUsdMethodChips(isCashAppAvailable, hasBankTransfer = true)drops ACH and Wire when the rail is hidden, so the cash list's USD row matches.Rain cardholders and users with no card see no change.
Reviewer notes
CardFundOptions.testgains auseCardProvidermock.CardFundOptionsimportsgetUsdMethodChipsfromDepositUsdOptions, which now pulls in that hook.Testing
jest components/DepositOption components/Card lib/utils: 50 suites, 739 tests pass.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.