Show every cash currency behind "Show more" on Deposit with cash - #2607
Merged
Merged
Conversation
"Deposit with cash" only expanded to MXN: the screen kept its own allowlist of codes, left over from when each row fetched its payment methods from TransFi. Chips now come from the committed corridor list, so "Show more" lists every currency in localCurrencies.tsx after the featured four, and the chooser's "+N" counts them all. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
"Show more" on Deposit with cash now lists all 16 local currencies instead of adding only MXN.
CARD_FUND_LOCAL_CURRENCIESin that list's order (AED, ARS, COP, GHS, IDR, KES, MXN, MYR, NGN, PEN, UGX, ZMW).DEPOSIT_CASH_CURRENCY_COUNTis derived from the full list, so the "+N" circle on the chooser's Cash row goes from +4 to +15.Why
DepositCashOptionskept its own allowlist (ADDITIONAL_LOCAL_CURRENCY_CODES = ['MXN']). It dates from when each row fetched its payment-method chips from TransFi, so every extra currency cost a request. Chips now come from the committedCARD_FUND_LOCAL_PAYMENT_METHODSmap, so that reason no longer applies, and the card-fund "Cash deposit" group already shows all 16. A new corridor added tolocalCurrencies.tsxnow shows up here too.For reviewers
master. This one is cut fromqa.useMemo.isTransfiAvailable); that's unchanged.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.