feat(deposit): offer Apple Pay on qa builds only - #2608
Merged
Merged
Conversation
Apple Pay (Onramper's widget) is still being tested, so gate its USD row and chip behind isDevFeatureEnabled: shown on qa/preview, hidden in production until launch. Without Apple Pay, a Wirex cardholder outside the US has no USD method at all, so the cash list hides its USD row rather than opening an empty chooser. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apple Paychip behindisDevFeatureEnabled, so it shows on qa/preview builds and stays hidden in production. The gate isisApplePayEnabled()inDepositUsdOptions.tsx; delete it at launch.Test plan
depositUsdOptions.test.tsx: the existing tests run with the flag on, and new tests cover production (row hidden, chip dropped, empty chips when USD has no method).CardFundOptions.test.tsxalready fails onqabecausereact-native-mmkvdoesn't load under jest. This PR doesn't touch it.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.