Fixed off by one error in packet size, and datatype of keep_alive - #28
Merged
Conversation
Member
|
Ah, they changed keep_alives on me Why are you adding one to the uncompressed_len? |
Member
|
Ok So I don't understand why it's there but it fixes the bug, sooooo in it goes |
nickelpro
pushed a commit
that referenced
this pull request
Jan 2, 2015
Fixed off by one error in packet size, and datatype of keep_alive
Member
|
Ah, figured it out. It's only for uncompressed packets: 1166fc5 I was forgetting to add the length of the 0 value data_length field |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep Alive packed send from the server
b'\x06\x00\x00\xc5\xf6\xf3\t'Keep Alive packet sent back to server
b'\x05\x00\x00\xc5\xf6\xf3\t'This would cause the minecraft server to drop the client because it failed to decode the packet