fix(wallets): prevent account-change listener leak on reconnect in XBullAdapter (closes #840) - #841
Closed
guptakumarranjeet150 wants to merge 1 commit into
Conversation
Contributor
|
Closing this PR — it was opened against an issue that wasn't assigned to you. To avoid duplicate work, please wait for an issue to be assigned before submitting a PR for it. Feel free to comment on the issue to request assignment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #840
Fixes account-change listener leakage in by unsubscribing the previous registration before registering a new one during repeated invocations, ensuring at most one active listener is maintained with the wallet and preventing post-disconnect state mutation.
Key Changes
Verification