Skip to content

STR-473 :: Refactor string-api to use go-lib - #136

Merged
alcalawil merged 15 commits into
developfrom
task/wil/str-473
Mar 16, 2023
Merged

STR-473 :: Refactor string-api to use go-lib#136
alcalawil merged 15 commits into
developfrom
task/wil/str-473

Conversation

@alcalawil

@alcalawil alcalawil commented Mar 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor
  1. run the Core API
  2. Run the Iframe + SDK
  3. Complete a transaction

Everything should work as usual
image

@alcalawil
alcalawil changed the base branch from main to develop March 10, 2023 23:58
saito-sv
saito-sv reviewed Mar 13, 2023
View reviewed changes
Comment thread api/api.go Outdated
Comment thread api/api.go Outdated
Comment thread api/handler/login_test.go Outdated
Comment thread api/handler/quotes.go
Comment thread api/handler/user_test.go Outdated
Comment thread pkg/service/auth.go Outdated
Comment thread pkg/service/cost.go Outdated
Comment thread pkg/service/device.go Outdated
Comment thread pkg/service/executor.go Outdated
Comment thread pkg/service/verification.go Outdated
ocasta181
ocasta181 reviewed Mar 13, 2023
View reviewed changes
Comment thread pkg/service/user.go Outdated
ocasta181
ocasta181 reviewed Mar 13, 2023
View reviewed changes
Comment thread api/middleware/middleware.go
@alcalawil alcalawil mentioned this pull request Mar 15, 2023
Merged
ocasta181
ocasta181 reviewed Mar 15, 2023
View reviewed changes
Comment thread pkg/internal/common/util.go Outdated
Comment thread api/middleware/middleware.go
Comment thread api/api.go Outdated
ocasta181
ocasta181 reviewed Mar 15, 2023
View reviewed changes
Comment thread pkg/repository/asset.go Outdated
Comment thread pkg/repository/asset.go Outdated
ocasta181
ocasta181 reviewed Mar 15, 2023
View reviewed changes
Comment thread api/api.go Outdated
Comment thread api/api.go Outdated
ocasta181
ocasta181 requested changes Mar 15, 2023
View reviewed changes
Comment thread pkg/service/checkout.go Outdated
saito-sv
saito-sv reviewed Mar 16, 2023
View reviewed changes

@saito-sv saito-sv left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alcalawil
alcalawil merged commit 1f150f0 into develop Mar 16, 2023
@alcalawil
alcalawil deleted the task/wil/str-473 branch March 16, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocasta181 ocasta181 ocasta181 approved these changes
+1 more reviewer
@saito-sv saito-sv saito-sv approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alcalawil @ocasta181 @saito-sv