update version and clean .env.example - #30
Merged
Conversation
saito-sv
previously approved these changes
Apr 1, 2023
frostbournesb
self-requested a review
April 1, 2023 02:04
frostbournesb
suggested changes
Apr 1, 2023
frostbournesb
left a comment
Contributor
There was a problem hiding this comment.
I think some of the urls are wrong, shouldn't it be
#### PRODUCTION
# VITE_IFRAME_URL=https://iframe.string-api.xyz
# VITE_API_URL=https://api.string-api.xyz
#### DEVELOPMENT
# VITE_IFRAME_URL=https://iframe-app.dev.string-api.xyz
# VITE_API_URL=https://string-api.dev.string-api.xyz
#### SANDBOX
# VITE_IFRAME_URL=https://iframe-app.dev.string-api.xyz
# VITE_API_URL=https://api.sandbox.string-api.xyz
#### LOCAL
VITE_IFRAME_URL=http://localhost:4040
VITE_API_URL=http://localhost:5555
VITE_STRING_API_KEY=str...
#### ANALYTICS
VITE_ANALYTICS_LIB_PK=
VITE_ANALYTICS_SUBDOMAIN_URL=https://metrics.string.xyz
frostbournesb
approved these changes
Apr 3, 2023
alcalawil
approved these changes
Apr 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.