Skip to content

Feature/organization#7

Merged
FarouqJalabi merged 11 commits into
mainfrom
feature/organization
Sep 5, 2024
Merged

Feature/organization#7
FarouqJalabi merged 11 commits into
mainfrom
feature/organization

Conversation

@FarouqJalabi

Copy link
Copy Markdown
Collaborator

Ability to create organisations through gem.
Didn't add get, update, delete because kaukes didn't used them. todo for later.

@FarouqJalabi FarouqJalabi self-assigned this Sep 4, 2024
Comment on lines +50 to +56
# Updates organisation
# @param [Hash] attributes
# @option attributes [String] :name (optional)
# @option attributes [String] :description (optional)
# @option attributes [Integer] :default_prompt_id (optional)
# @option attributes [String] :language (optional)
# @return [Swiftner::API::Organisation]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the comments!

@mrtnin mrtnin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Looks good

@mrtnin

mrtnin commented Sep 5, 2024

Copy link
Copy Markdown
Contributor

@FarouqJalabi
Could you in this PR, add a line about the changes added in this PR in the changelog under unreleased?
https://github.com/Swiftner/swiftner_ruby/blob/main/CHANGELOG.md

Comment thread CHANGELOG.md Outdated
## [Unreleased]

## [0.0.3] - 2024-09-05
- Organisation service.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this good?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but you could write a sentence of the change itself. Maybe, if you have it, add a link to the PR

@FarouqJalabi
FarouqJalabi requested review from mrtnin and removed request for HaavGa and mmichelli September 5, 2024 11:51
Comment thread CHANGELOG.md Outdated
@FarouqJalabi
FarouqJalabi merged commit d28e5ec into main Sep 5, 2024
@FarouqJalabi
FarouqJalabi deleted the feature/organization branch September 5, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants