Skip to content

Fix for 'createInstance' bug during init #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkucharz merged 1 commit into from
Feb 2, 2018
Merged

Fix for 'createInstance' bug during init #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/cli/src/commands/helpers/create-instance.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,20 @@
import format from 'chalk'

import logger from '../../utils/debug'
import session from '../../utils/session'
import { echo, echon, error } from '../../utils/print-tools'

const { debug } = logger('cmd-helpers-socket')

export const createInstance = async (instanceName, session) => {
export const createInstance = async (instanceName) => {
let newInstance = null
try {
debug('Creating Instance')
echo()
echon(4)('Creating Syncano Instance... ')
newInstance = await session.createInstance(instanceName)
} catch (err) {
debug(err)
echo()
echo()
if (err.message === 'No such API Key.') {
Expand Down
1 change: 1 addition & 0 deletions packages/cli/src/commands/init.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ class InitCmd {
}

if (!project && !instance) {
debug('no project, no instance')
const newInstance = createInstance()

await this.init.addConfigFiles({ instance: newInstance.name })
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/commands/socket-deploy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export default class SocketDeployCmd {

// Create Instance if --create-instance provided
if (cmd.createInstance) {
await createInstance(cmd.createInstance, this.session)
await createInstance(cmd.createInstance)
await this.init.addConfigFiles({ instance: cmd.createInstance })
} else {
// If not, we have to check if we have a project attached to any instance
Expand Down
2 changes: 1 addition & 1 deletion packages/lib-js-client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"license": "MIT",
"repository": {
"type": "git",
"url": "https://github.com/Syncano/syncano-client-js.git"
"url": "https://github.com/Syncano/syncano-node.git"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/lib-js-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"lodash": "^4.17.4",
"lodash.merge": "^4.6.0",
"proxyquire": "^1.8.0",
"syncano-validator": "^0.0.1"
"@syncano/validate": "0.7.1"
},
"devDependencies": {
"rimraf": "^2.6.2",
Expand Down