Skip to content

Sync files as a default option when adding hosting #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkucharz merged 2 commits into from
Oct 14, 2018
Merged

Sync files as a default option when adding hosting #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
980caf4
chore(cli:hosting): sync files as a default option
mkucharz Oct 14, 2018
434c8a6
fix(cli:unit): fix tests
mkucharz Oct 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/src/commands/hosting-add.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class HostingAdd {
type: 'confirm',
name: 'confirm',
message: p(2)('Do you want to sync files now?'),
default: false
default: true
}]

const response = await inquirer.prompt(syncQuestion)
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/tests/unit/commands-hosting-add.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ describe('[commands] Add Hosting', function () {
type: 'confirm',
name: 'confirm',
message: p(2)('Do you want to sync files now?'),
default: false
default: true
}

await hostingAdd.syncNewHosting()
Expand Down
4 changes: 2 additions & 2 deletions packages/tests/e2e/cli/hosting.test-e2e.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ describe('CLI Hosting', function () {
.on(/Do you want to use BrowserRouter/)
.respond('\n')
.on(/sync files now/)
.respond('\n')
.respond('N\n')
.stdout(/sync files use: npx s hosting sync/)
.code(0)
.end(done)
Expand All @@ -55,7 +55,7 @@ describe('CLI Hosting', function () {
.on(/Do you want to use BrowserRouter/)
.respond('\n')
.on(/sync files now/)
.respond('\n')
.respond('N\n')
.stdout(/sync files use: npx s hosting sync/)
.code(0)
.end(done)
Expand Down