Critical bugs - #36
Merged
Merged
Conversation
- Fix FileDirValue: create directory before validation to prevent initialization errors - Fix FileNameValue: restore proper setValue logic to prevent CSV generation failures - Add bug fixes documentation to dev guide Resolves analysis crashes and missing results files
- Move validation logic to validate() method for better design consistency - Centralize type checking, empty string validation, and directory existence checks - Maintain existing functionality with no breaking changes
- Move all validation logic (type checking, directory creation, validation) to validate() method - Simplify setValue() to just set value and call validate() - Cleaner separation of concerns while maintaining all functionality - Tested and confirmed working with command line analyses
- Move os.makedirs() from validate() to setValue() for better separation of concerns - validate() now only validates without side effects - setValue() handles setting value, validation, and directory creation - Tested and confirmed working with command line analyses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.