Codify REQ-CNST-003 and Tier-2/3/4 folder gates (#5035) - #5040
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Folder-organization gate for #5035 (tracked by #4669)
Registers REQ-CNST-003 and sets a 12-file fallback in the existing public-package count test. Adds guidance for private folders with at least 10 direct Python files, a per-file concern map for IL-0 packages with at least 20, and registration-derived Tier-3 atomicity checks with documented exceptions.
The 12-file fallback applies only where a package has no
FILE_COUNT_LIMITSentry. Current explicit package limits:Validation:
pre-commit run --all-filespassed, including the policy gate. The configured full test gate passed: 44,594 passed, 610 skipped, 34 xfailed.Audit deviation (REQ-002, REQ-003, REQ-012)
The verified plan added a recursive public-package walk and a new 17-file limit for
server/tools/tools_execution, with a second policy approval. Issue #5035 instead specifies changing the existing test's fallback from 10 to 12 and states that no package should newly fail. During implementation the requester explicitly rejected adding the 17-file exception as moving the goalpost. This PR therefore retains the existing two-level walk and adds no new package limit or approval row. Public packages below depth two remain outside this file-count test; expanding that scope requires a separately reviewed decision.The
core/fixture/paths.pyregression from REQ-012 is now included because that package is reached by the existing walk and protects the root-only shim exclusion. The depth-three regression is omitted with the recursive expansion. The audit's three literal-plan MISSING findings require deviation review before merge; a green test run alone does not resolve that review.The PR targets
develop; #4669 remains open until promotion tomain.