Skip to content

refactor(recipe): reduce rule-engine complexity - #5043

Merged
Trecek merged 11 commits into
developfrom
impl-recipe-rule-complexity-4992-20260914
Sep 15, 2026
Merged

Trecek merged 11 commits into
developfrom
impl-recipe-rule-complexity-4992-20260914

Conversation

@Trecek

@Trecek Trecek commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Recipe validation had complexity debt in 58 functions across 40 rule files. This change consolidates repeated routing, binding, and document analysis and separates cohesive parsing and graph queries. All 58 candidates have lower measured complexity; 37 now score 10 or below.

Preserves rule registration and entry signatures, diagnostic text and ordering, and existing error behavior. Fifteen focused characterization cases cover the preservation gaps identified in the plan. The full candidate and helper measurements are recorded in #4992.

Validation:

  • Full repository suite: 47,692 passed, 781 skipped, 34 expected failures.
  • Recipe suite: 5,621 passed, 225 skipped; all six focused groups passed.
  • pre-commit run --all-files passed; all 140 registered rule definitions and signatures match the baseline.
  • The complexity checker completed in unchanged warn mode with one documented warning: _no_go_route_findings scores 12. Its complete per-audit route analysis remains together; no thresholds or exemptions were changed.

Closes #4992.

@Trecek
Trecek added this pull request to the merge queue Sep 15, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 15, 2026
@Trecek
Trecek added this pull request to the merge queue Sep 15, 2026
Merged via the queue into develop with commit 148607f Sep 15, 2026
14 of 16 checks passed
@Trecek
Trecek deleted the impl-recipe-rule-complexity-4992-20260914 branch September 15, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant