refactor(recipe): reduce rule-engine complexity - #5043
Merged
Merged
Conversation
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recipe validation had complexity debt in 58 functions across 40 rule files. This change consolidates repeated routing, binding, and document analysis and separates cohesive parsing and graph queries. All 58 candidates have lower measured complexity; 37 now score 10 or below.
Preserves rule registration and entry signatures, diagnostic text and ordering, and existing error behavior. Fifteen focused characterization cases cover the preservation gaps identified in the plan. The full candidate and helper measurements are recorded in #4992.
Validation:
pre-commit run --all-filespassed; all 140 registered rule definitions and signatures match the baseline._no_go_route_findingsscores 12. Its complete per-audit route analysis remains together; no thresholds or exemptions were changed.Closes #4992.