refactor(tests): reduce complexity debt in test suites - #5047
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor the test/support complexity debt tracked in #4993 across 37 files. Shared scope-selection, AST-scanning, fixture, fault-injection, and routing operations replace duplicated logic while preserving existing assertions, diagnostics, ordering, and cleanup.
The issue body contains all 48 candidate measurements and all introduced or relocated function measurements.
Local validation
pre-commit run --all-files: passed.Outstanding smoke validation
Both credentialed live smoke cases failed:
The smoke setup and live test body are unchanged. Assertions and launch-name sets were preserved, and no passing smoke result is claimed.
Refs #4993.