Skip to content

fix: preserve Case 57 compact preview - #66

Merged
tannerlinsley merged 1 commit into
mainfrom
taren/charts-0.7.2-case57-preview
Aug 7, 2026
Merged

fix: preserve Case 57 compact preview#66
tannerlinsley merged 1 commit into
mainfrom
taren/charts-0.7.2-case57-preview

Conversation

@tannerlinsley

@tannerlinsley tannerlinsley commented Aug 7, 2026

Copy link
Copy Markdown
Member

Summary

  • suppress the Case 57 color legend only for compact catalog previews
  • retain the Species legend in the full catalog view
  • assert the 288x192 main plot and right marginal bars remain visible

Validation

  • focused Case 57 and catalog preview tests
  • root TypeScript check
  • React catalog sync check
  • Prettier and diff checks

Summary by CodeRabbit

  • Bug Fixes

    • Improved compact scatter chart previews by hiding the legend while retaining the main plot and marginal bars.
    • Full-size scatter charts continue to display the legend.
  • Tests

    • Added regression coverage for compact and full-size scatter chart rendering.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 73e0a60e-8da4-438e-adf9-e7666ac34b29

📥 Commits

Reviewing files that changed from the base of the PR and between 2758103 and 7131884.

📒 Files selected for processing (3)
  • .changeset/bright-penguins-preview.md
  • benchmarks/conformance/cases/57-scatter-marginal-histograms/tanstack.ts
  • packages/react-charts-catalog/src/preview.test.tsx

📝 Walkthrough

Walkthrough

The scatter-marginal chart now accepts a showLegend flag. Full renders keep the species legend. Compact catalog previews hide it. Tests cover both layouts, and a patch Changeset records the update.

Changes

Scatter preview legend behavior

Layer / File(s) Summary
Legend control and preview wiring
benchmarks/conformance/cases/57-scatter-marginal-histograms/tanstack.ts
The chart accepts showLegend, renders the species legend only when enabled, and disables it for catalog previews while keeping it enabled for the primary chart.
Preview regression coverage and release metadata
packages/react-charts-catalog/src/preview.test.tsx, .changeset/bright-penguins-preview.md
Tests verify compact and full scatter-marginal layouts. The Changeset records the patch release and preview legend behavior.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: full-conformance

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the fix to preserve the Case 57 compact preview, which matches the primary pull request objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch taren/charts-0.7.2-case57-preview

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Aug 7, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 7131884

Command Status Duration Result
nx run charts-workspace:ci-distributed ✅ Succeeded 4m 51s View ↗
nx run charts-workspace:package-check ✅ Succeeded 2m 12s View ↗
nx run charts-workspace:benchmark-check ✅ Succeeded 1m 6s View ↗

☁️ Nx Cloud last updated this comment at 2026-08-07 22:32:09 UTC

@tannerlinsley
tannerlinsley merged commit 173ebb4 into main Aug 7, 2026
19 checks passed
@github-actions github-actions Bot mentioned this pull request Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant