Skip to content

Remove SubField API#607

Merged
crutchcorn merged 3 commits into
mainfrom
remove-subfield
Mar 4, 2024
Merged

Remove SubField API#607
crutchcorn merged 3 commits into
mainfrom
remove-subfield

Conversation

@crutchcorn

Copy link
Copy Markdown
Member

This PR removes the subfield API from FieldAPI, as:

  1. We're removing the implicit ability to create a new FieldAPI from a parent's name in react-core (Array and provider refactor #588)
  2. This API adds a ton of complexity (especially around typings)
  3. It's just as easy to new FieldAPI with a new name

@nx-cloud

nx-cloud Bot commented Feb 25, 2024

Copy link
Copy Markdown

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8f70742. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@codecov-commenter

codecov-commenter commented Feb 25, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.75%. Comparing base (9602113) to head (8f70742).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #607      +/-   ##
==========================================
- Coverage   87.78%   87.75%   -0.04%     
==========================================
  Files          30       30              
  Lines         794      792       -2     
  Branches      179      179              
==========================================
- Hits          697      695       -2     
  Misses         92       92              
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fulopkovacs fulopkovacs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 lgtm!

@crutchcorn crutchcorn merged commit 6009dce into main Mar 4, 2024
@crutchcorn crutchcorn deleted the remove-subfield branch March 4, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants