fix(hotkeys): mac hotkeys follow Apple's Human Interface Guidelines - #139
fix(hotkeys): mac hotkeys follow Apple's Human Interface Guidelines#139IanWorley wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughmacOS hotkey display formatting now orders modifiers according to Apple HIG, including ChangesmacOS modifier ordering
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant formatForDisplay
participant toAppleHIGModifierOrder
participant resolveModifier
formatForDisplay->>toAppleHIGModifierOrder: normalize macOS hotkey ordering
toAppleHIGModifierOrder->>resolveModifier: resolve Mod for macOS
resolveModifier-->>toAppleHIGModifierOrder: resolved modifier
toAppleHIGModifierOrder-->>formatForDisplay: ordered hotkey for display mapping
Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
7811d82 to
7f0efab
Compare
7f0efab to
1b94343
Compare
🎯 Changes
✅ Checklist
pnpm run test:pr.🚀 Release Impact
Summary by CodeRabbit
Bug Fixes
Mod+Shift+Snow display as⇧ ⌘ Son macOS.Documentation