test(preact-query/useSuspenseQuery): add regression tests for suspense release on programmatic 'setQueryData' by sukvvon · Pull Request #11248 · TanStack/query

sukvvon · 2026-08-22T02:03:16Z

🎯 Changes

Port the four regression tests added to react-query's useSuspenseQuery.test.tsx in #11036 to preact-query. The underlying fix lives in packages/query-core/src/queryObserver.ts (fetchOptimistic), so preact-query already gets the runtime behavior for free — this PR only adds equivalent test coverage:

should release suspense when setQueryData is called while fetch is in-flight
should release suspense when streamedQuery receives first chunk
should release suspense when setQueryData is called before component mounts
should NOT release suspense when setQueryData is called with undefined

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Bug Fixes
- Suspense now releases correctly when data becomes available during an active fetch or when the first streamed result arrives.
- Preloaded query data is rendered immediately when available before component mount.
- Suspense continues correctly when query data remains undefined.

…e release on programmatic 'setQueryData'

nx-cloud · 2026-08-22T02:03:43Z

View your CI Pipeline Execution ↗ for commit 27ed1c2

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	4m 39s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	7s	View ↗

☁️ Nx Cloud last updated this comment at 2026-08-22 02:09:15 UTC

github-actions · 2026-08-22T02:04:25Z

🚀 Changeset Version Preview

10 package(s) bumped directly, 15 bumped as dependents.

🟨 Minor bumps

Package	Version	Reason
`@tanstack/angular-query-experimental`	5.101.4 → 5.102.0	Changeset
`@tanstack/eslint-plugin-query`	5.101.4 → 5.102.0	Changeset
`@tanstack/preact-query`	5.101.4 → 5.102.0	Changeset
`@tanstack/query-broadcast-client-experimental`	5.101.4 → 5.102.0	Changeset
`@tanstack/query-core`	5.101.4 → 5.102.0	Changeset
`@tanstack/react-query`	5.101.4 → 5.102.0	Changeset
`@tanstack/solid-query`	5.101.4 → 5.102.0	Changeset
`@tanstack/vue-query`	5.101.4 → 5.102.0	Changeset
`@tanstack/angular-query-persist-client`	5.101.4 → 5.102.0	Dependent
`@tanstack/preact-query-devtools`	5.101.4 → 5.102.0	Dependent
`@tanstack/preact-query-persist-client`	5.101.4 → 5.102.0	Dependent
`@tanstack/query-async-storage-persister`	5.101.4 → 5.102.0	Dependent
`@tanstack/query-devtools`	5.101.4 → 5.102.0	Dependent
`@tanstack/query-persist-client-core`	5.101.4 → 5.102.0	Dependent
`@tanstack/query-sync-storage-persister`	5.101.4 → 5.102.0	Dependent
`@tanstack/react-query-devtools`	5.101.4 → 5.102.0	Dependent
`@tanstack/react-query-next-experimental`	5.101.4 → 5.102.0	Dependent
`@tanstack/react-query-persist-client`	5.101.4 → 5.102.0	Dependent
`@tanstack/solid-query-devtools`	5.101.4 → 5.102.0	Dependent
`@tanstack/solid-query-persist-client`	5.101.4 → 5.102.0	Dependent

🟩 Patch bumps

Package	Version	Reason
`@tanstack/lit-query`	0.2.11 → 0.2.12	Changeset
`@tanstack/svelte-query`	6.1.38 → 6.1.39	Changeset
`@tanstack/svelte-query-devtools`	6.1.38 → 6.1.39	Dependent
`@tanstack/svelte-query-persist-client`	6.1.38 → 6.1.39	Dependent
`@tanstack/vue-query-devtools`	6.1.38 → 6.1.39	Dependent

coderabbitai · 2026-08-22T02:05:09Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: cee456ed-251f-4bf1-b3cd-25b1d2530ad3

📥 Commits

Reviewing files that changed from the base of the PR and between c9dba07 and 27ed1c2.

📒 Files selected for processing (1)

packages/preact-query/src/__tests__/useSuspenseQuery.test.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.

📝 Walkthrough

Walkthrough

The test suite now covers how useSuspenseQuery handles manually supplied data, streamed query chunks, preloaded data, and undefined data during unresolved fetches.

Changes

Suspense query tests

Layer / File(s)	Summary
Suspense data readiness scenarios `packages/preact-query/src/__tests__/useSuspenseQuery.test.tsx`	Added tests for manual data updates, first streamed chunks, preloaded data, and continued suspension when data is `undefined`. Added the `experimental_streamedQuery` import.

Estimated code review effort: 2 (Simple) | ~15 minutes

Merge Risk: ⚪ Minimal · up to 27ed1

This change adds regression tests without modifying published runtime behavior or production configuration, so no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description explains the four regression tests, confirms testing, and correctly marks the change as dev-only with no release impact.
Title check	✅ Passed	The title clearly identifies the Preact Query test file and the regression coverage for Suspense release after setQueryData.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch test/preact-query-suspense-set-query-data

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-08-22T02:05:56Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11248

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11248

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11248

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11248

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11248

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11248

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11248

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11248

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11248

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11248

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11248

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11248

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11248

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11248

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11248

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11248

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11248

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11248

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11248

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11248

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11248

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11248

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11248

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11248

commit: 27ed1c2

github-actions · 2026-08-22T02:06:19Z

size-limit report 📦

Path	Size
react full	11.98 KB (0%)
react minimal	8.92 KB (0%)

test(preact-query/useSuspenseQuery): add regression tests for suspens…

27ed1c2

…e release on programmatic 'setQueryData'

sukvvon self-assigned this Aug 22, 2026

sukvvon merged commit abd81f4 into main Aug 22, 2026
9 checks passed

sukvvon deleted the test/preact-query-suspense-set-query-data branch August 22, 2026 02:17

Navigation Menu

Uh oh!

Uh oh!

test(preact-query/useSuspenseQuery): add regression tests for suspense release on programmatic 'setQueryData' - #11248

test(preact-query/useSuspenseQuery): add regression tests for suspense release on programmatic 'setQueryData'#11248
sukvvon merged 1 commit into
mainfrom
test/preact-query-suspense-set-query-data

sukvvon commented Aug 22, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

nx-cloud Bot commented Aug 22, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 22, 2026

Uh oh!

coderabbitai Bot commented Aug 22, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

pkg-pr-new Bot commented Aug 22, 2026

Uh oh!

github-actions Bot commented Aug 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

sukvvon commented Aug 22, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

nx-cloud Bot commented Aug 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 22, 2026

🚀 Changeset Version Preview

🟨 Minor bumps

🟩 Patch bumps

Uh oh!

coderabbitai Bot commented Aug 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

pkg-pr-new Bot commented Aug 22, 2026

Uh oh!

github-actions Bot commented Aug 22, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Aug 22, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Aug 22, 2026 •

edited

Loading

coderabbitai Bot commented Aug 22, 2026 •

edited

Loading