inline isServer for proper DCE

[schiller-manuel]

Summary by CodeRabbit

• Refactor
  • Improved server-side rendering compatibility and build-time optimization across React, Solid, and Vue routing.
  • Preserved existing server-rendered state handling and client-side behavior.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 98a923ef-ff84-4170-bfc7-8f502f80e433

📥 Commits

Reviewing files that changed from the base of the PR and between 4fa1df7 and 8c88574.

📒 Files selected for processing (4)

• packages/react-router/src/link.tsx
• packages/react-router/src/useRouterState.tsx
• packages/solid-router/src/useRouterState.tsx
• packages/vue-router/src/useRouterState.tsx

---

📝 Walkthrough

Walkthrough

The React, Solid, and Vue router implementations inline isServer ?? router.isServer in SSR conditions. Existing server state handling and client subscriptions remain unchanged. React Link includes comments for bundler dead-code elimination.

Changes

SSR detection

Layer / File(s)	Summary
Inline server checks packages/react-router/src/link.tsx, packages/react-router/src/useRouterState.tsx, packages/solid-router/src/useRouterState.tsx, packages/vue-router/src/useRouterState.tsx	SSR conditions now evaluate isServer ?? router.isServer inline. React Link documents the inline form required for bundler constant folding.

Estimated code review effort: 2 (Simple) | ~5 minutes

Suggested reviewers: sheraff

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes inlining isServer to enable proper dead-code elimination, which is the main change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch bundlesize-inline-isserver

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[nx-cloud]

View your CI Pipeline Execution ↗ for commit 5f744df

Command	Status	Duration	Result
nx run-many --target=build --exclude=examples/*...	✅ Succeeded	2m 12s	View ↗

---

☁️ Nx Cloud last updated this comment at 2026-08-08 00:12:04 UTC

[github-actions]

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

[pkg-pr-new]

More templates

• tanstack-router-vue-example-basic-jsx
• tanstack-router-vue-example-basic-file-based-jsx
• tanstack-router-vue-example-basic-file-based-sfc
• tanstack-router-solid-example-authenticated-routes
• tanstack-router-solid-example-authenticated-routes-firebase
• tanstack-router-solid-example-basic
• tanstack-router-solid-example-basic-default-search-params
• tanstack-router-solid-example-basic-devtools-panel
• tanstack-router-solid-example-basic-file-based
• tanstack-router-solid-example-basic-non-nested-devtools
• tanstack-router-solid-example-basic-solid-query
• tanstack-router-solid-example-basic-solid-query-file-based
• tanstack-router-solid-example-basic-ssr-file-based
• tanstack-router-solid-example-basic-ssr-streaming-file-based
• tanstack-router-solid-example-basic-virtual-file-based
• tanstack-router-solid-example-basic-virtual-inside-file-based
• tanstack-router-solid-example-deferred-data
• tanstack-router-solid-i18n-paraglide
• tanstack-router-solid-example-kitchen-sink
• tanstack-router-solid-example-kitchen-sink-file-based
• tanstack-router-solid-example-kitchen-sink-solid-query
• tanstack-router-solid-example-kitchen-sink-solid-query-file-based
• tanstack-router-solid-example-large-file-based
• tanstack-router-solid-example-location-masking
• tanstack-router-solid-example-navigation-blocking
• tanstack-router-solid-example-quickstart
• tanstack-router-solid-example-quickstart-esbuild-file-based
• tanstack-router-solid-example-quickstart-file-based
• tanstack-router-solid-example-quickstart-rspack-file-based
• tanstack-router-solid-example-quickstart-webpack-file-based
• @tanstack/router-solid-mono-simple
• router-solid-mono-simple-lazy
• router-solid-monorepo-solid-query
• tanstack-router-solid-example-scroll-restoration
• tanstack-solid-router-search-validator-adapters
• tanstack-solid-start-example-basic
• tanstack-solid-start-example-basic-auth
• tanstack-solid-start-example-basic-authjs
• tanstack-solid-start-example-basic-cloudflare
• tanstack-solid-start-example-basic-netlify
• tanstack-solid-start-example-basic-nitro
• tanstack-start-example-basic-solid-query
• tanstack-solid-start-example-basic-static
• tanstack-solid-start-bun-hosting
• tanstack-solid-start-example-convex-better-auth
• tanstack-solid-start-example-counter
• tanstack-solid-start-i18n-paraglide
• tanstack-solid-start-example-large
• tanstack-solid-start-streaming-data-from-server-functions
• tanstack-solid-start-example-supabase-basic
• tanstack-solid-start-tailwind-v4
• tanstack-router-solid-example-view-transitions
• tanstack-router-solid-example-with-framer-motion
• tanstack-router-solid-example-with-trpc
• tanstack-router-react-example-authenticated-routes
• tanstack-router-react-example-authenticated-routes-firebase
• tanstack-router-react-example-basic
• tanstack-router-react-example-basic-default-search-params
• tanstack-router-react-example-basic-devtools-panel
• tanstack-router-react-example-basic-file-based
• tanstack-router-react-example-basic-non-nested-devtools
• tanstack-router-react-example-react-query
• tanstack-router-react-example-basic-react-query-file-based
• tanstack-router-react-example-basic-ssr-file-based
• tanstack-router-react-example-basic-ssr-streaming-file-based
• tanstack-router-react-example-basic-virtual-file-based
• tanstack-router-react-example-basic-virtual-inside-file-based
• tanstack-router-react-example-deferred-data
• tanstack-router-i18n-paraglide
• tanstack-router-react-example-kitchen-sink
• tanstack-router-react-example-kitchen-sink-file-based
• tanstack-router-react-example-kitchen-sink-react-query
• tanstack-router-react-example-kitchen-sink-react-query-file-based
• tanstack-router-react-example-large-file-based
• tanstack-router-react-example-location-masking
• tanstack-router-react-example-navigation-blocking
• tanstack-router-react-example-quickstart
• tanstack-router-react-example-quickstart-esbuild-file-based
• tanstack-router-react-example-quickstart-file-based
• tanstack-router-react-example-quickstart-rspack-file-based
• tanstack-router-react-example-quickstart-webpack-file-based
• router-monorepo-react-query
• router-mono-simple
• router-mono-simple-lazy
• tanstack-router-react-example-scroll-restoration
• tanstack-search-validator-adapters
• tanstack-start-example-bare
• tanstack-start-example-basic
• tanstack-start-example-basic-auth
• tanstack-router-react-example-basic-authjs
• tanstack-start-example-basic-cloudflare
• tanstack-start-example-basic-react-query
• tanstack-start-example-basic-rsbuild
• tanstack-start-example-basic-static
• tanstack-start-bun-hosting
• tanstack-start-example-clerk-basic
• tanstack-start-example-convex-trellaux
• tanstack-start-example-counter
• tanstack-start-i18n-paraglide
• tanstack-start-example-large
• tanstack-start-example-material-ui
• tanstack-start-example-rscs
• tanstack-start-streaming-data-from-server-functions
• tanstack-start-example-supabase-basic
• tanstack-start-tailwind-v4
• tanstack-start-example-trellaux
• tanstack-start-example-workos
• tanstack-router-react-example-view-transitions
• tanstack-router-react-example-with-framer-motion
• tanstack-router-react-example-with-trpc
• tanstack-router-react-example-with-trpc-react-query

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7996

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7996

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7996

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7996

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7996

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7996

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7996

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7996

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7996

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7996

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7996

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7996

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7996

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7996

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7996

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7996

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7996

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7996

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7996

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7996

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7996

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7996

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7996

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7996

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7996

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7996

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7996

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7996

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7996

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7996

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7996

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7996

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7996

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7996

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7996

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7996

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7996

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7996

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7996

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7996

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7996

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7996

commit: 8c88574

[github-actions]

Bundle Size Benchmarks

This pull request does not affect bundle size in any measured scenario.

[codspeed-hq]

Merging this PR will regress 5 benchmarks

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
❌ 5 regressed benchmarks
✅ 171 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Mode	Benchmark	BASE	HEAD	Efficiency
❌	Memory	mem server error-paths not-found (solid)	410.8 KB	845.3 KB	-51.4%
❌	Memory	mem client unique-location-churn (solid)	341.6 KB	566.6 KB	-39.71%
❌	Memory	mem server error-paths redirect (vue)	300.2 KB	442.5 KB	-32.16%
❌	Memory	mem server peak-large-page (solid)	813.2 KB	995.8 KB	-18.34%
❌	Memory	mem client navigation-churn (solid)	563.1 KB	594 KB	-5.2%
⚡	Memory	mem server server-fn-churn (vue)	3,927.3 KB	274.8 KB	×14
⚡	Memory	mem server peak-large-page (react)	2,064 KB	952.8 KB	×2.2
⚡	Simulation	ssr request loop (solid)	152.3 ms	145.5 ms	+4.66%
⚡	Memory	mem server error-paths not-found (vue)	333 KB	320.5 KB	+3.92%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

---

_{Comparing bundlesize-inline-isserver (8c88574) with main (4fa1df7)}