refactor: remove Link transition state - #8043
Conversation
|
View your CI Pipeline Execution ↗ for commit 143b1c5
☁️ Nx Cloud last updated this comment at |
🚀 Changeset Version Preview4 package(s) bumped directly, 19 bumped as dependents. 🟩 Patch bumps
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe React, Solid, and Vue Link implementations no longer track or expose ChangesLink transition state removal
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bundle Size Benchmarks
The following scenarios have bundle-size changes compared with the baseline:
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better. |
Merging this PR will regress 0 benchmarks
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | client-async-pipeline navigation loop (react) |
138.9 ms | 104.4 ms | +32.98% |
| ⚡ | Simulation | client-async-pipeline navigation loop (solid) |
200 ms | 176.5 ms | +13.31% |
| ⚡ | Memory | mem server error-paths not-found (vue) |
777.5 KB | 688.9 KB | +12.85% |
| ⚡ | Simulation | client-route-tree-scale navigation loop (solid) |
375.4 ms | 334.7 ms | +12.15% |
| ⚡ | Simulation | client-rewrites navigation loop (solid) |
236.2 ms | 213 ms | +10.91% |
| ⚡ | Simulation | client-loaders navigation loop (solid) |
230.1 ms | 208.6 ms | +10.26% |
| ⚡ | Simulation | client-route-tree-scale navigation loop (react) |
189.1 ms | 172.7 ms | +9.47% |
| ⚡ | Simulation | client-rewrites navigation loop (react) |
155.1 ms | 142.3 ms | +9.04% |
| ⚡ | Simulation | client-control-flow navigation loop (solid) |
178.9 ms | 164.1 ms | +8.98% |
| ⚡ | Simulation | client-side navigation loop (react) |
138.1 ms | 126.9 ms | +8.8% |
| ⚡ | Simulation | client-links navigation loop (react) |
319.3 ms | 296.7 ms | +7.61% |
| ⚡ | Simulation | client-search-params navigation loop (solid) |
298.2 ms | 278.5 ms | +7.07% |
| ⚡ | Simulation | client-history navigation loop (solid) |
173 ms | 163.2 ms | +6.01% |
| ⚡ | Memory | mem server error-paths unmatched (solid) |
592.5 KB | 560.5 KB | +5.7% |
| ⚡ | Simulation | client-history navigation loop (react) |
133.6 ms | 126.8 ms | +5.36% |
| ⚡ | Simulation | client-control-flow navigation loop (react) |
180.5 ms | 171.4 ms | +5.27% |
| ⚡ | Simulation | client-loaders navigation loop (react) |
136.3 ms | 129.5 ms | +5.24% |
| ⚡ | Memory | mem server error-paths redirect (solid) |
379.9 KB | 361.2 KB | +5.18% |
| ⚡ | Memory | mem server serialization-payload (vue) |
4.5 MB | 4.3 MB | +4.94% |
| ⚡ | Memory | mem server aborted-requests (react) |
905.7 KB | 864.6 KB | +4.75% |
| ... | ... | ... | ... | ... | ... |
ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing remove-link-is-transitioning (143b1c5) with main (7e93431)
Summary
isTransitioningstate from the React, Solid, and Vue adaptersdata-transitioningand removeisTransitioningfrom Link render-prop/slot types and valuesCompatibility
isTransitioninganddata-transitioningwere undocumented, but the attribute was observable and Solid/Vue exposed the state at runtime. React advertised the field in its type without passing it at runtime. Please confirm that removing this accidental API is acceptable before merge.Testing
CI=1 NX_DAEMON=false pnpm nx run-many --target=test:unit --projects=@tanstack/react-router,@tanstack/solid-router,@tanstack/vue-router --outputStyle=stream --skipRemoteCacheCI=1 NX_DAEMON=false pnpm nx run-many --target=test:types --projects=@tanstack/react-router,@tanstack/solid-router,@tanstack/vue-router --outputStyle=stream --skipRemoteCacheCI=1 NX_DAEMON=false pnpm nx run-many --target=test:eslint --projects=@tanstack/react-router,@tanstack/solid-router,@tanstack/vue-router --outputStyle=stream --skipRemoteCachepnpm exec changeset status --since=mainSummary by CodeRabbit
isTransitioningstate from React, Solid, and Vue router links.data-transitioningattribute from rendered links.isActive.