Skip to content

refactor: remove Link transition state - #8043

Merged
Sheraff merged 1 commit into
mainfrom
remove-link-is-transitioning
Aug 12, 2026
Merged

refactor: remove Link transition state#8043
Sheraff merged 1 commit into
mainfrom
remove-link-is-transitioning

Conversation

@Sheraff

@Sheraff Sheraff commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • remove the undocumented per-Link isTransitioning state from the React, Solid, and Vue adapters
  • stop emitting data-transitioning and remove isTransitioning from Link render-prop/slot types and values
  • remove the obsolete Vue regression test and add patch changesets for all three router packages

Compatibility

isTransitioning and data-transitioning were undocumented, but the attribute was observable and Solid/Vue exposed the state at runtime. React advertised the field in its type without passing it at runtime. Please confirm that removing this accidental API is acceptable before merge.

Testing

  • CI=1 NX_DAEMON=false pnpm nx run-many --target=test:unit --projects=@tanstack/react-router,@tanstack/solid-router,@tanstack/vue-router --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run-many --target=test:types --projects=@tanstack/react-router,@tanstack/solid-router,@tanstack/vue-router --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run-many --target=test:eslint --projects=@tanstack/react-router,@tanstack/solid-router,@tanstack/vue-router --outputStyle=stream --skipRemoteCache
  • pnpm exec changeset status --since=main

Summary by CodeRabbit

  • Breaking Changes
    • Removed the undocumented isTransitioning state from React, Solid, and Vue router links.
    • Removed the data-transitioning attribute from rendered links.
    • Link child callbacks and Vue slots now receive only isActive.

@nx-cloud

nx-cloud Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 143b1c5

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 10m 40s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 20s View ↗

☁️ Nx Cloud last updated this comment at 2026-08-11 16:40:45 UTC

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

4 package(s) bumped directly, 19 bumped as dependents.

🟩 Patch bumps

Package Version Reason
@tanstack/react-router 1.170.25 → 1.170.26 Changeset
@tanstack/router-core 1.171.21 → 1.171.22 Changeset
@tanstack/solid-router 1.170.24 → 1.170.25 Changeset
@tanstack/vue-router 1.170.23 → 1.170.24 Changeset
@tanstack/react-start 1.168.42 → 1.168.43 Dependent
@tanstack/react-start-client 1.168.23 → 1.168.24 Dependent
@tanstack/react-start-rsc 0.1.41 → 0.1.42 Dependent
@tanstack/react-start-server 1.167.30 → 1.167.31 Dependent
@tanstack/router-cli 1.167.27 → 1.167.28 Dependent
@tanstack/router-generator 1.167.27 → 1.167.28 Dependent
@tanstack/router-plugin 1.168.29 → 1.168.30 Dependent
@tanstack/router-vite-plugin 1.167.29 → 1.167.30 Dependent
@tanstack/solid-start 1.168.41 → 1.168.42 Dependent
@tanstack/solid-start-client 1.168.23 → 1.168.24 Dependent
@tanstack/solid-start-server 1.167.30 → 1.167.31 Dependent
@tanstack/start-client-core 1.170.21 → 1.170.22 Dependent
@tanstack/start-plugin-core 1.171.33 → 1.171.34 Dependent
@tanstack/start-server-core 1.169.25 → 1.169.26 Dependent
@tanstack/start-static-server-functions 1.167.26 → 1.167.27 Dependent
@tanstack/start-storage-context 1.167.23 → 1.167.24 Dependent
@tanstack/vue-start 1.168.40 → 1.168.41 Dependent
@tanstack/vue-start-client 1.167.26 → 1.167.27 Dependent
@tanstack/vue-start-server 1.167.30 → 1.167.31 Dependent

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8b3158c2-9ac7-40c4-8c18-18a1f866cd41

📥 Commits

Reviewing files that changed from the base of the PR and between 7e93431 and 143b1c5.

📒 Files selected for processing (5)
  • .changeset/remove-link-transition-state.md
  • packages/react-router/src/link.tsx
  • packages/solid-router/src/link.tsx
  • packages/vue-router/src/link.tsx
  • packages/vue-router/tests/link.test.tsx
💤 Files with no reviewable changes (1)
  • packages/vue-router/tests/link.test.tsx

📝 Walkthrough

Walkthrough

The React, Solid, and Vue Link implementations no longer track or expose isTransitioning or data-transitioning. Their child callback state now contains only isActive. The Vue test for the removed behavior was deleted, and a patch changeset documents the change.

Changes

Link transition state removal

Layer / File(s) Summary
React Link state removal
packages/react-router/src/link.tsx, .changeset/remove-link-transition-state.md
React navigation no longer updates transition state. Link props and function children no longer expose transition data.
Solid Link state removal
packages/solid-router/src/link.tsx
Solid navigation no longer subscribes to resolution state. Transition attributes and callback state were removed.
Vue Link state removal and validation
packages/vue-router/src/link.tsx, packages/vue-router/tests/link.test.tsx
Vue Link results, navigation handling, computed props, attributes, and slots no longer include transition state. The related pending-navigation test was removed.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

  • TanStack/router#7952: Both changes modify React Router’s useLinkProps, but this PR removes transition state while that PR addresses render bailout optimization.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the main change: removing Link transition state.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-link-is-transitioning

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 64ec8e03761f
  • Measured at: 2026-08-11T16:30:18.352Z
  • Baseline source: history:7e93431ae9ff
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

Scenario Current (gzip) Delta vs baseline Initial gzip Raw Brotli Trend
react-router.minimal 83.84 KiB -83 B (-0.10%) 83.70 KiB 262.51 KiB 72.91 KiB ██▁▁▁▁▁▁▁▁▁▁
react-router.full 87.35 KiB -77 B (-0.09%) 87.21 KiB 274.22 KiB 76.04 KiB ██▁▁▁▁▁▁▁▁▁▁
solid-router.minimal 33.17 KiB -73 B (-0.21%) 33.04 KiB 96.31 KiB 29.90 KiB ██▁▁▁▁▁▁▁▁▁▁
solid-router.full 38.00 KiB -70 B (-0.18%) 37.88 KiB 110.95 KiB 34.20 KiB ██▁▁▁▁▁▁▁▁▁▁
vue-router.minimal 49.46 KiB -60 B (-0.12%) 49.34 KiB 138.03 KiB 44.64 KiB ██▁▁▁▁▁▁▁▁▁▁
vue-router.full 55.04 KiB -57 B (-0.10%) 54.92 KiB 156.21 KiB 49.56 KiB ██▁▁▁▁▁▁▁▁▁▁
react-start.minimal 96.66 KiB -93 B (-0.09%) 96.52 KiB 304.72 KiB 83.79 KiB ██▁▁▁▁▁▁▁▁▁▁
react-start.deferred-hydration 97.38 KiB -95 B (-0.10%) 96.54 KiB 306.07 KiB 84.38 KiB ██▁▁▁▁▁▁▁▁▁▁
react-start.full 99.84 KiB -81 B (-0.08%) 99.70 KiB 314.44 KiB 86.44 KiB ██▁▁▁▁▁▁▁▁▁▁
react-start.rsbuild.minimal 99.98 KiB -84 B (-0.08%) 99.81 KiB 315.25 KiB 86.24 KiB ▂▂▂▂▆██████▁
react-start.rsbuild.minimal-iife 100.39 KiB -84 B (-0.08%) 100.22 KiB 316.19 KiB 86.60 KiB ▂▂▂▂▆██████▁
react-start.rsbuild.full 103.31 KiB -82 B (-0.08%) 103.14 KiB 325.35 KiB 88.91 KiB ▁▁▁▁▅██████▁
solid-start.minimal 45.94 KiB -74 B (-0.16%) 45.81 KiB 137.37 KiB 40.87 KiB ██▁▁▁▁▁▁▁▁▁▁
solid-start.deferred-hydration 49.00 KiB -80 B (-0.16%) 45.87 KiB 144.83 KiB 43.72 KiB ██▁▁▁▁▁▁▁▁▁▁
solid-start.full 51.03 KiB -61 B (-0.12%) 50.90 KiB 152.76 KiB 45.22 KiB ██▁▁▁▁▁▁▁▁▁▁
vue-start.minimal 65.48 KiB -64 B (-0.10%) 65.35 KiB 188.86 KiB 58.33 KiB ██▁▁▁▁▁▁▁▁▁▁
vue-start.full 69.30 KiB -60 B (-0.08%) 69.18 KiB 201.13 KiB 61.58 KiB ██▁▁▁▁▁▁▁▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-new Bot commented Aug 11, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@8043

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8043

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8043

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@8043

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8043

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@8043

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@8043

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8043

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@8043

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@8043

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@8043

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@8043

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@8043

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@8043

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@8043

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@8043

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@8043

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@8043

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8043

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@8043

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8043

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@8043

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8043

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8043

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@8043

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@8043

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@8043

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@8043

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8043

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@8043

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@8043

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8043

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@8043

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@8043

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8043

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@8043

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8043

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8043

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@8043

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@8043

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@8043

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@8043

commit: 143b1c5

@codspeed-hq

codspeed-hq Bot commented Aug 11, 2026

Copy link
Copy Markdown

Merging this PR will regress 0 benchmarks

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 25 improved benchmarks
❌ 7 (👁 7) regressed benchmarks
✅ 148 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation client-async-pipeline navigation loop (react) 138.9 ms 104.4 ms +32.98%
Simulation client-async-pipeline navigation loop (solid) 200 ms 176.5 ms +13.31%
Memory mem server error-paths not-found (vue) 777.5 KB 688.9 KB +12.85%
Simulation client-route-tree-scale navigation loop (solid) 375.4 ms 334.7 ms +12.15%
Simulation client-rewrites navigation loop (solid) 236.2 ms 213 ms +10.91%
Simulation client-loaders navigation loop (solid) 230.1 ms 208.6 ms +10.26%
Simulation client-route-tree-scale navigation loop (react) 189.1 ms 172.7 ms +9.47%
Simulation client-rewrites navigation loop (react) 155.1 ms 142.3 ms +9.04%
Simulation client-control-flow navigation loop (solid) 178.9 ms 164.1 ms +8.98%
Simulation client-side navigation loop (react) 138.1 ms 126.9 ms +8.8%
Simulation client-links navigation loop (react) 319.3 ms 296.7 ms +7.61%
Simulation client-search-params navigation loop (solid) 298.2 ms 278.5 ms +7.07%
Simulation client-history navigation loop (solid) 173 ms 163.2 ms +6.01%
Memory mem server error-paths unmatched (solid) 592.5 KB 560.5 KB +5.7%
Simulation client-history navigation loop (react) 133.6 ms 126.8 ms +5.36%
Simulation client-control-flow navigation loop (react) 180.5 ms 171.4 ms +5.27%
Simulation client-loaders navigation loop (react) 136.3 ms 129.5 ms +5.24%
Memory mem server error-paths redirect (solid) 379.9 KB 361.2 KB +5.18%
Memory mem server serialization-payload (vue) 4.5 MB 4.3 MB +4.94%
Memory mem server aborted-requests (react) 905.7 KB 864.6 KB +4.75%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing remove-link-is-transitioning (143b1c5) with main (7e93431)

Open in CodSpeed

@Sheraff
Sheraff merged commit 1aafca9 into main Aug 12, 2026
26 checks passed
@Sheraff
Sheraff deleted the remove-link-is-transitioning branch August 12, 2026 07:52
@github-actions github-actions Bot mentioned this pull request Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant