Run Charts catalog sandboxes from public examples - #1159
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughThe charts catalog now supports native React ChangesCharts catalog migration
Estimated code review effort: 4 (Complex) | ~45 minutes Merge Risk: ⚪ Minimal · up to The catalog schema compatibility change is merge-ready after normal checks and review; no actionable merge-blocking risk remains. Sequence Diagram(s)sequenceDiagram
participant CatalogIndex
participant ChartsCatalogServer
participant CatalogExampleGenerator
participant ReactExample
CatalogIndex->>ChartsCatalogServer: provide version 1 or version 2 case
ChartsCatalogServer->>ChartsCatalogServer: resolve entries.example or entries.tanstack
ChartsCatalogServer->>CatalogExampleGenerator: load resolved entry
CatalogExampleGenerator->>ReactExample: generate React renderer for example.tsx
ReactExample-->>ChartsCatalogServer: render catalog example
Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | 01fe174 | Commit Preview URL Branch Preview URL |
Aug 14 2026, 07:39 PM |
Updates the Charts catalog consumer to accept the self-contained example schema while retaining the existing adapter schema during rollout. Public example.tsx is now the first sandbox file and runs through a hidden React entrypoint; legacy catalog entries continue to work unchanged.\n\nThis must land before the corresponding TanStack Charts catalog migration.\n\nValidation: full repository pre-commit suite; focused catalog tests; TypeScript; formatting; type-aware lint.
Summary by CodeRabbit
New Features
example.tsx.Compatibility
Validation