feat: 진행률 차트 및 일정 위젯 실데이터 연동 - #64
Merged
Merged
Conversation
📝 WalkthroughWalkthrough캘린더 이벤트에 Changes캘린더 실데이터 위젯
진행률 차트 표시 조정
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant DashboardWidgetCatalog
participant CalendarWidget
participant TodayScheduleWidget
participant useCalendarEventsByWorkspaceId
participant getCalendarEventsByWorkspaceId
participant Supabase
DashboardWidgetCatalog->>CalendarWidget: workspaceId 전달
DashboardWidgetCatalog->>TodayScheduleWidget: workspaceId 전달
CalendarWidget->>useCalendarEventsByWorkspaceId: workspaceId로 이벤트 조회
TodayScheduleWidget->>useCalendarEventsByWorkspaceId: workspaceId로 이벤트 조회
useCalendarEventsByWorkspaceId->>getCalendarEventsByWorkspaceId: 캘린더 이벤트 요청
getCalendarEventsByWorkspaceId->>Supabase: calendar_events 조회
Supabase-->>getCalendarEventsByWorkspaceId: event_type 포함 이벤트 반환
CalendarWidget-->>CalendarWidget: 월별 이벤트 날짜 계산
TodayScheduleWidget-->>TodayScheduleWidget: 오늘 일정 정렬 및 매핑
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/entities/side-project/schedule-event/model/schedule-event.selectors.ts`:
- Around line 6-12: Update formatIsoDate and the current-date calculation in
buildCalendarMonthFromEvents to extract year, month, and day in KST rather than
using local-time Date getters. Reuse the existing KST formatting approach, such
as Intl.DateTimeFormat, so computed calendar dates consistently match event.date
values from formatIsoDateInKst across client and SSR timezones.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 49bee589-db48-46b0-be6a-4470678b669f
📒 Files selected for processing (11)
src/entities/calendar-event/api/get-calendar-events-by-workspace-id.tssrc/entities/calendar-event/model/calendar-event.mapper.tssrc/entities/calendar-event/model/calendar-event.types.tssrc/entities/side-project/schedule-event/index.tssrc/entities/side-project/schedule-event/model/schedule-event.mock.tssrc/entities/side-project/schedule-event/model/schedule-event.selectors.tssrc/features/manage-progress-chart/ui/ProgressChartView.tsxsrc/views/dashboard/config/widget-catalog.tsxsrc/views/progress-chart/ui/ProgressChartPage.tsxsrc/widgets/side-project/dashboard-calendar/ui/Calendar.tsxsrc/widgets/side-project/dashboard-today-schedule/ui/TodaySchedule.tsx
💤 Files with no reviewable changes (2)
- src/views/progress-chart/ui/ProgressChartPage.tsx
- src/entities/side-project/schedule-event/model/schedule-event.mock.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
작업 내용
task집계값은 기존useTasksByWorkspaceId와createProgressChartSummary를 재사용하도록 정리했고,calendar_events는 위젯 전용 selector를 추가해 월간 캘린더/오늘 일정에 맞는 형태로 파생했습니다.workspaceId를 캘린더/오늘 일정 위젯까지 전달하도록 연결했습니다.작업 결과
변경 사항
Added
calendar_events→ 위젯 UI용 파생 데이터를 만드는 selector 추가CalendarMonthScheduleEvent[]Changed
calendar_events조회 시event_type까지 함께 읽도록 확장eventType필드 추가workspaceId전달Fixed
실행화면
테스트
리뷰 체크리스트
feature/*->develop, 배포 시develop또는release/*->main)Type/#issue-number/description형식을 따릅니다.console.log, 주석, 임시 코드를 제거했습니다.리뷰 요청사항
calendar_events를 위젯에서 재사용하기 위해event_type과 날짜/시간 파생 로직을 selector로 분리했는데, 이 구조가 엔티티 책임 범위에 맞는지 봐주시면 좋겠습니다.npm run typecheck는 이번 변경분 문제가 아니라 기존develop의resend모듈 누락 이슈로 전체 통과가 막히는 상태입니다.관련 이슈
Closes #62
Summary by CodeRabbit