feat:랜딩 템플릿 미리보기 및 대시보드 진입 개선(#66) - #66
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (1)
📝 WalkthroughWalkthrough랜딩 템플릿별 대시보드 이미지를 선택에 따라 표시하도록 변경하고, 사이드 프로젝트 워크스페이스의 기본 진입 경로를 대시보드로 수정했습니다. Changes템플릿 미리보기 및 워크스페이스 진입
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant 사용자
participant TemplatesSection
participant Image
사용자->>TemplatesSection: 템플릿 선택
TemplatesSection->>TemplatesSection: 미리보기 경로 조회
TemplatesSection->>Image: 선택된 이미지 표시
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/app/workspaces/[workspaceId]/page.tsx (1)
18-25: 📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win불필요한 리다이렉트 분기 조건을 제거해주세요.
팀 프로젝트를 포함해 모든 워크스페이스 목적의 기본 진입 경로가 대시보드로 통일되었습니다. 결과적으로 목적(purpose)을 검사해 개별적으로
/dashboard로 보내던 기존 조건문들은 데드 코드가 되었으므로 제거하는 것이 깔끔합니다.♻️ 제안하는 수정안
- if (workspace.purpose === 'store-operation') { - redirect(`/workspaces/${workspaceId}/dashboard`); - } - if (workspace.purpose === 'side-project') { - redirect(`/workspaces/${workspaceId}/dashboard`); - } - redirect(`/workspaces/${workspaceId}/dashboard`);🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/app/workspaces/`[workspaceId]/page.tsx around lines 18 - 25, Remove the redundant purpose checks for “store-operation” and “side-project” from the workspace page redirect logic. Keep the single unconditional redirect to the workspace dashboard, preserving the existing `/workspaces/${workspaceId}/dashboard` destination for every workspace.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/widgets/landing/landing-templates/config/templates.ts`:
- Line 34: Update the previewImage values in the landing templates, including
the entries at the referenced locations, to use lowercase English filenames with
hyphens only. Rename the corresponding files under public/images/landing/ to
match the new paths and preserve each template’s intended image.
---
Outside diff comments:
In `@src/app/workspaces/`[workspaceId]/page.tsx:
- Around line 18-25: Remove the redundant purpose checks for “store-operation”
and “side-project” from the workspace page redirect logic. Keep the single
unconditional redirect to the workspace dashboard, preserving the existing
`/workspaces/${workspaceId}/dashboard` destination for every workspace.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 93d06a0e-7945-4f5f-bf57-d2f3e30cc5a2
⛔ Files ignored due to path filters (3)
public/images/landing/매장 대시보드.pngis excluded by!**/*.png,!public/**public/images/landing/사이드 프로젝트 대시보드.pngis excluded by!**/*.png,!public/**public/images/landing/팀플 - 대시보드.pngis excluded by!**/*.png,!public/**
📒 Files selected for processing (3)
src/app/workspaces/[workspaceId]/page.tsxsrc/widgets/landing/landing-templates/config/templates.tssrc/widgets/landing/landing-templates/ui/TemplatesSection.tsx
| tagBg: '#ede9fe', | ||
| tagText: '#7008e7', | ||
| tags: ['업무 분담 보드', '회의록', '자료실', '캘린더', '그룹 채팅'], | ||
| previewImage: '/images/landing/팀플 - 대시보드.png', |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value
정적 파일명에 영문 소문자와 하이픈(-)을 사용해주세요.
이미지 파일명에 공백이나 한글이 포함되어 있으면 일부 브라우저, CDN, 또는 배포 환경(Vercel 등)에서 인코딩 문제로 인해 404 에러나 렌더링 실패가 발생할 수 있습니다. 안정적인 서비스 운영을 위해 영문 소문자와 하이픈으로만 구성된 파일명(예: team-dashboard.png, side-project-dashboard.png)으로 변경하는 것을 권장합니다.
(실제 프로젝트 내 public/images/landing/ 경로의 파일 이름도 함께 변경해야 합니다.)
Also applies to: 49-49, 64-64
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/widgets/landing/landing-templates/config/templates.ts` at line 34, Update
the previewImage values in the landing templates, including the entries at the
referenced locations, to use lowercase English filenames with hyphens only.
Rename the corresponding files under public/images/landing/ to match the new
paths and preserve each template’s intended image.
JiWoongE
self-requested a review
July 16, 2026 03:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
작업 내용
작업 결과
변경 사항
Added
Changed
Fixed
실행화면
테스트
npm run typechecknpm run lintgit diff --checknpm run build(기존.next/lock점유로 실행 불가)리뷰 체크리스트
feature/*->develop, 배포 시develop또는release/*->main)Type/#issue-number/description형식을 따릅니다.console.log, 주석, 임시 코드를 제거했습니다.리뷰 요청사항
관련 이슈
Closes #66
Summary by CodeRabbit
새 기능
버그 수정